Remotetap extension concept #10963
Open
Remotetap extension concept #10963
+63
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please create this PR in contrib? We will not have new components in this repository right now. |
|
Ah okay, then I will move the component back to contrib and will only update the processorhelper logic in core |
wildum
force-pushed
the
remotetap-extension-concept
branch
from
1872d48
to
ad62aab
Compare
|
@atoulme I moved the component from this PR to contrib: open-telemetry/opentelemetry-collector-contrib#34872. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the core part of the remote tap concept described here: open-telemetry/opentelemetry-collector-contrib#34096
This will be used by the new version of the remotetap extension in contrib.
This new version uses the processorhelper to tap into the processor pipeline. ALL processors using the processorhelper to be created will automatically support the extension.
To see what a full version could look like you can check this POC: #10962
When no remotetap stream is open, the additional work on the processor pipeline is negligible (1 map read / proc consumption if the extension is not enabled, 2 map read / proc consumption if the extension is enabled but no streams are open)
Idealy, in the future, the extension could tap into all kinds of components. Taping into the processors that use the processorhelper pkg is the first easy step in this direction.