Minor additions to self-observability metrics #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-bebbington
requested review from
bogdandrutu,
dmitryax,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
james-bebbington
changed the title
| if procStat, err := pmv.proc.Stat(); err == nil { | ||
| stats.Record(context.Background(), mCPUSeconds.M(int64(procStat.CPUTime()))) | ||
| if times, err := pmv.proc.Times(); err == nil { | ||
| stats.Record(context.Background(), mCPUSeconds.M(int64(times.Total()))) |
There was a problem hiding this comment.
This should really be a double but I didn't change it to maintain backwards compatibility
There was a problem hiding this comment.
We should plan to fix this in a follow-up.
james-bebbington
force-pushed
the
add-uptime-and-rss-metrics
branch
from
825e0b2
to
2dbd112
Compare
Codecov Report
@@ Coverage Diff @@
## master #1549 +/- ##
==========================================
- Coverage 91.87% 91.83% -0.05%
==========================================
Files 255 255
Lines 17561 17570 +9
==========================================
+ Hits 16135 16136 +1
- Misses 1020 1025 +5
- Partials 406 409 +3
Continue to review full report at Codecov.
|
james-bebbington
force-pushed
the
add-uptime-and-rss-metrics
branch
3 times, most recently
from
a7e8cd8
to
e060514
Compare
nilebox
reviewed
Aug 16, 2020
| Name: mUptime.Name(), | ||
| Description: mUptime.Description(), | ||
| Measure: mUptime, | ||
| Aggregation: view.Sum(), |
There was a problem hiding this comment.
Why not last value? Then you wouldn't need to calculate delta (i.e. record prevTimeUnixNano) and just report the current value, as far as I undertand.
There was a problem hiding this comment.
Tbh I'm not super familiar with the OpenCensus APIs, and this may not be the right way to do this. But the reason for choosing Sum was so this is created as a Counter metric. If I use LastValue, this is created as a Gauge.
nilebox
approved these changes
Aug 17, 2020
… on non-Linux OSs
james-bebbington
force-pushed
the
add-uptime-and-rss-metrics
branch
from
e060514
to
91d2f3d
Compare
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
…metry#1697) * breaking(zipkin): removes servicName from zipkin exporter. Resource detector provides a serviceName in all cases, hence we can relay on span resource to obtain the serviceName. Also this is required by the spec https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk_exporters/zipkin.md\#service-name (open-telemetry#1549). * docs(zipkin): adds changelog. * chore(examples/zipkin): updates example accordingly. Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
…emetry#1549) Bumps golang from 1.18.1-stretch to 1.18.2-stretch. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added uptime metric as documented as desired in the Observability Goals.
Also:
total_sys_memory_bytesmetric which records total virtually mapped memorycpu_secondsto work on OSs other than Linux.