Change goldendataset to use the new internal metrics structs #1697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
requested review from
dmitryax,
james-bebbington,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1697 +/- ##
==========================================
- Coverage 92.37% 92.36% -0.01%
==========================================
Files 265 265
Lines 19909 19938 +29
==========================================
+ Hits 18390 18415 +25
- Misses 1089 1093 +4
Partials 430 430
Continue to review full report at Codecov.
|
bogdandrutu
force-pushed
the
newmodel
branch
2 times, most recently
from
791cfa0
to
8764a3b
Compare
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
dmitryax
approved these changes
Aug 31, 2020
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
…metry#1697) * breaking(zipkin): removes servicName from zipkin exporter. Resource detector provides a serviceName in all cases, hence we can relay on span resource to obtain the serviceName. Also this is required by the spec https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk_exporters/zipkin.md\#service-name (open-telemetry#1549). * docs(zipkin): adds changelog. * chore(examples/zipkin): updates example accordingly. Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #1695
Removes support for Summary metrics for the moment since the new internal structs don't support that.