Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert ocexporter to the new interfaces #1571

Merged
merged 1 commit into from
Aug 18, 2020

Conversation

bogdandrutu
Copy link
Member

Depends on #1570

@codecov
Copy link

codecov bot commented Aug 18, 2020

Codecov Report

Merging #1571 into master will decrease coverage by 0.01%.
The diff coverage is 88.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1571      +/-   ##
==========================================
- Coverage   91.83%   91.81%   -0.02%     
==========================================
  Files         254      254              
  Lines       17452    17480      +28     
==========================================
+ Hits        16027    16050      +23     
- Misses       1016     1022       +6     
+ Partials      409      408       -1     
Impacted Files Coverage Δ
exporter/opencensusexporter/opencensus.go 88.88% <80.95%> (+0.95%) ⬆️
consumer/pdatautil/pdatautil.go 85.29% <100.00%> (+0.67%) ⬆️
exporter/exportertest/sink_exporter.go 100.00% <100.00%> (ø)
exporter/opencensusexporter/factory.go 100.00% <100.00%> (ø)
service/defaultcomponents/defaults.go 85.18% <100.00%> (ø)
exporter/exporterhelper/metricshelper.go 92.30% <0.00%> (-7.70%) ⬇️
service/builder/pipelines_builder.go 81.45% <0.00%> (-1.33%) ⬇️
translator/internaldata/resource_to_oc.go 83.33% <0.00%> (+2.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed65294...c10543f. Read the comment docs.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu merged commit 5a523bf into open-telemetry:master Aug 18, 2020
@bogdandrutu bogdandrutu deleted the ocexporter2 branch August 18, 2020 01:13
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
* Fix stdout TestStdoutTimestamp failure with sleep

Ensure the test condition is valid by introducing minimal sleep
durations before and after a timestamp is measured.

Resolves open-telemetry#1571

* Add changes to changelog

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants