Remove old exporter and exporter factory #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
requested review from
dmitryax,
james-bebbington,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
dmitryax
approved these changes
Aug 25, 2020
| // If exporter is of the old type (can manipulate on OC metrics only), | ||
| // use ExporterFactoryOld.CreateMetricsExporter. | ||
| return factoryBase.(component.ExporterFactoryOld).CreateMetricsExporter(logger, cfg) | ||
| // If exporter is of the new type (can manipulate on internal data structure), |
There was a problem hiding this comment.
do we still need this comment?
There was a problem hiding this comment.
Will followup with removing of the ConsumerOld and will remove that as well.
Codecov Report
@@ Coverage Diff @@
## master #1630 +/- ##
==========================================
- Coverage 91.90% 91.86% -0.05%
==========================================
Files 254 254
Lines 17548 17486 -62
==========================================
- Hits 16128 16064 -64
Misses 1014 1014
- Partials 406 408 +2
Continue to review full report at Codecov.
|
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
…pen-telemetry#1630) * Bump github.com/shirou/gopsutil/v3 from 3.22.4 to 3.22.5 in /tests Bumps [github.com/shirou/gopsutil/v3](https://github.com/shirou/gopsutil) from 3.22.4 to 3.22.5. - [Release notes](https://github.com/shirou/gopsutil/releases) - [Commits](shirou/gopsutil@v3.22.4...v3.22.5) --- updated-dependencies: - dependency-name: github.com/shirou/gopsutil/v3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * go mod tidy Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: jeffreyc-splunk <jeffreyc@splunk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.