Refactor metrics scraper to use interface for Scrapers #1945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main advantage is that entire functionality that can be added to the receiver can be encapsulated in one object, which means some scrapers can be consumed from external packages. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
requested review from
dmitryax,
james-bebbington,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1945 +/- ##
=======================================
Coverage 91.46% 91.47%
=======================================
Files 284 284
Lines 16772 16774 +2
=======================================
+ Hits 15341 15344 +3
+ Misses 1001 1000 -1
Partials 430 430
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main advantage is that entire functionality that can be added to the receiver can be encapsulated in one object,
which means some scrapers can be consumed from external packages.
Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com