Fix panic in otlp traces to zipkin #1963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkositsyn
requested review from
bogdandrutu,
dmitryax,
james-bebbington,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1963 +/- ##
==========================================
- Coverage 91.52% 91.48% -0.05%
==========================================
Files 280 280
Lines 16492 16495 +3
==========================================
- Hits 15095 15090 -5
- Misses 967 974 +7
- Partials 430 431 +1
Continue to review full report at Codecov.
|
bogdandrutu
approved these changes
Oct 15, 2020
|
@bogdandrutu Should be good to go |
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
* add otlp trace http exporter * remove `WithTraces*` options * address discussions * run make precommit * rename WithURLPath option
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixing a bug. There was a panic converting internal traces to zipkin, which occured if there were both a valid span and a nil span. With only nil span the error was about absence of trace id. No check for nil span was present - that is the bug.
Link to tracking Issue: might be connected to #1845
Testing: added test with 2 spans