Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug-level message on error for Jaeger Exporter #1964

Conversation

jpkrohling
Copy link
Member

@jpkrohling jpkrohling commented Oct 15, 2020

Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de

Important (read before submitting)

Description:
When trying to get the OpenTelemetry Collector to work with Jaeger, it's currently not easy to determine whether a batch has failed to be sent to Jaeger, as there are no logs recorded anywhere.
This PR adds a debug-level message with the error. Users doing an initial setup, or having problems, can enable debug logging and will be able to identify what's wrong.

Example output:

2020-10-15T14:35:55.203+0200	DEBUG	jaegerexporter/exporter.go:95	failed to push trace data to Jaeger	{"component_kind": "exporter", "component_type": "jaeger", "component_name": "jaeger/auth", "error": "rpc error: code = Unknown desc = authentication didn't succeed"}

Link to tracking Issue: n/a

Testing: manual test

Documentation: n/a

exporter/jaegerexporter/exporter.go Outdated Show resolved Hide resolved
@jpkrohling jpkrohling force-pushed the jpkrohling/add-debug-message-when-failed-to-send-spans-to-jaeger branch from 5711639 to 8c2b8dc Compare October 15, 2020 12:57
@jpkrohling
Copy link
Member Author

PR updated.

@codecov
Copy link

codecov bot commented Oct 15, 2020

Codecov Report

Merging #1964 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1964      +/-   ##
==========================================
+ Coverage   91.48%   91.49%   +0.01%     
==========================================
  Files         280      280              
  Lines       16500    16502       +2     
==========================================
+ Hits        15095    15099       +4     
+ Misses        974      973       -1     
+ Partials      431      430       -1     
Impacted Files Coverage Δ
exporter/jaegerexporter/exporter.go 88.23% <100.00%> (+0.73%) ⬆️
exporter/jaegerexporter/factory.go 92.30% <100.00%> (ø)
translator/internaldata/resource_to_oc.go 94.52% <0.00%> (+2.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac26601...ef6c7c2. Read the comment docs.

@bogdandrutu bogdandrutu reopened this Oct 15, 2020
@jpkrohling
Copy link
Member Author

Those are unrelated, right?

# github.com/open-telemetry/opentelemetry-collector-contrib/testbed/datasenders
datasenders/carbon.go:32:2: undefined: testbed.DataSenderBase
datasenders/sapm.go:31:2: undefined: testbed.DataSenderBase
datasenders/signalfx.go:31:2: undefined: testbed.DataSenderBase
?   	github.com/open-telemetry/opentelemetry-collector-contrib/testbed/datareceivers	[no test files]
FAIL	github.com/open-telemetry/opentelemetry-collector-contrib/testbed/stabilitytests [build failed]
FAIL	github.com/open-telemetry/opentelemetry-collector-contrib/testbed/tests [build failed]
make[1]: *** [Makefile.Common:49: test] Error 2
make[1]: Leaving directory '/tmp/opentelemetry-collector-contrib'
make: *** [Makefile:313: check-contrib] Error 2

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@jpkrohling jpkrohling force-pushed the jpkrohling/add-debug-message-when-failed-to-send-spans-to-jaeger branch from 8c2b8dc to ef6c7c2 Compare October 15, 2020 19:49
@jpkrohling
Copy link
Member Author

Rebased, hopefully the contrib-test is fixed by now?

@bogdandrutu bogdandrutu merged commit 9cecee1 into open-telemetry:master Oct 15, 2020
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants