remove locking from jaeger receiver start and stop processes #3070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bhautikpip have you confirmed that this is not needed? |
|
@bogdandrutu I have not tested this changes with multiple requests to see wether we would be requiring locks or not. I kinda followed the issue description. Any recommendation on best way to test this? |
|
I think the field |
|
Ran |
jrcamp
approved these changes
May 4, 2021
jpkrohling
approved these changes
May 5, 2021
dashpole
pushed a commit
to dashpole/opentelemetry-collector
that referenced
this pull request
Jun 14, 2021
…lemetry#3070) * remove locking from jaeger receiver start and stop processes * remove mutex field
6 tasks
ankitnayan
pushed a commit
to SigNoz/opentelemetry-collector
that referenced
this pull request
Jul 27, 2021
…lemetry#3070) * remove locking from jaeger receiver start and stop processes * remove mutex field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: <Describe what has changed.
Remove locking from start and stop functions - jaeger receiver
Link to tracking Issue:
#3041
Testing: < Describe what testing was performed and which tests were added.>
Documentation: < Describe the documentation added.>
Please delete paragraphs that you did not use before submitting.