Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove locking from jaeger receiver start and stop processes #3070

Merged
merged 2 commits into from
May 5, 2021
Merged

remove locking from jaeger receiver start and stop processes #3070

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42444c9
remove locking from jaeger receiver start and stop processes
bhautikpip Apr 30, 2021
ffed6a4
remove mutex field
bhautikpip May 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions receiver/jaegerreceiver/trace_receiver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,6 @@ type configuration struct {
// Receiver type is used to receive spans that were originally intended to be sent to Jaeger.
// This receiver is basically a Jaeger collector.
type jReceiver struct {
// mu protects the fields of this type
mu sync.Mutex

nextConsumer consumer.Traces
instanceName string

Expand Down Expand Up @@ -182,9 +179,6 @@ func (jr *jReceiver) collectorHTTPEnabled() bool {
}

func (jr *jReceiver) Start(_ context.Context, host component.Host) error {
jr.mu.Lock()
defer jr.mu.Unlock()

if err := jr.startAgent(host); err != nil {
return err
}
Expand All @@ -197,8 +191,6 @@ func (jr *jReceiver) Start(_ context.Context, host component.Host) error {
}

func (jr *jReceiver) Shutdown(ctx context.Context) error {
jr.mu.Lock()
defer jr.mu.Unlock()
var errs []error

if jr.agentServer != nil {
Expand Down