translate IntHistogram to Histogram in otlp_wrappers #3613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
reviewed
Jul 13, 2021
model/internal/otlp_wrapper.go
Outdated
Comment on lines
50
to
52
| Value: &otlpmetrics.Exemplar_AsDouble{ | ||
| AsDouble: float64(exemplar.Value), | ||
| }, |
There was a problem hiding this comment.
It should be AsInt correct?
There was a problem hiding this comment.
Right, I misinterpreted the comment in the proto about values being translated to float from int64 to include the values of the Exemplar.
model/internal/otlp_wrapper.go
Outdated
| @@ -38,6 +39,58 @@ func MetricsFromOtlp(req *otlpcollectormetrics.ExportMetricsServiceRequest) Metr | |||
| return MetricsWrapper{req: req} | |||
| } | |||
|
|
|||
| func intHistogramToHistogram(src *otlpmetrics.Metric_IntHistogram) *otlpmetrics.Metric_Histogram { | |||
There was a problem hiding this comment.
nit: usually I prefer public funcs at the top :)
There was a problem hiding this comment.
Moved this function to the bottom.
bogdandrutu
reviewed
Jul 13, 2021
codeboten
force-pushed
the
codeboten/deprecate-int-histogram
branch
from
9accefa
to
83e3c76
Compare
bogdandrutu
approved these changes
Jul 14, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Deprecating IntHistogram. As per https://github.com/open-telemetry/opentelemetry-proto/blob/f3b0ee0861d304f8f3126686ba9b01c106069cb0/opentelemetry/proto/metrics/v1/metrics.proto#L170, the OTLP receiver will translate
IntHistogramintoHistogram. Would love any pointers on how to improve the tests here, are there are utilities I've not used in the collector codebase to make the test less manual?Link to tracking Issue: Part of #3534
Testing: Added a test to ensure both
HistogramandIntHistogramare validHistogramafter translation.