translate IntGauge to Gauge in otlp_wrappers #3619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Consider a rebase for this so only the new changes are shown |
codeboten
force-pushed
the
codeboten/deprecate-intgauge
branch
from
09e28b2
to
5de38e4
Compare
Done! |
bogdandrutu
approved these changes
Jul 14, 2021
| } | ||
| } | ||
|
|
||
| func intExemplarToExemplar(src []otlpmetrics.IntExemplar) []*otlpmetrics.Exemplar { //nolint:staticcheck // SA1019 ignore this! |
There was a problem hiding this comment.
In a followup PR, we need to updated the change for the exemplars #2402, because we don't have DoubleExemplars anymore :)
So need to change the sed file, and regenerate the protos, and update the pdata generator to make Exemplars array of values.
There was a problem hiding this comment.
I see where the DoubleExemplar is in the sed file, though im not seeing where that's being utilized in the protos as is. They're all either Exemplar or IntExemplar, does the Double get dropped somewhere?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Deprecating IntGauge As per https://github.com/open-telemetry/opentelemetry-proto/blob/f3b0ee0861d304f8f3126686ba9b01c106069cb0/opentelemetry/proto/metrics/v1/metrics.proto#L156, the OTLP receiver will translate
IntGaugeintoGauge.Link to tracking Issue: Part of #3534
Testing: Added a test to ensure both
GaugeandIntGaugeare validGaugeafter translation.This change is built on top of #3613, will rebase once merged.