fix bool attribute equality #3688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Aneurysm9
approved these changes
Jul 21, 2021
bogdandrutu
approved these changes
Jul 21, 2021
mxiamxia
pushed a commit
to mxiamxia/opentelemetry-collector
that referenced
this pull request
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix a bug - Getting the bool value of a non-bool attribute returns false; therefore, equality of a false bool attribute and any non-bool attribute returned true. To fix this issue, the equality of attributes should assert the two attributes share a type.
Testing:
The respective unit test was updated to ensure this edge case was hit.