[chore] [exporterhelper] Simplify queue consumption logic #8982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8982 +/- ##
==========================================
+ Coverage 91.54% 91.55% +0.01%
==========================================
Files 316 315 -1
Lines 17117 17117
==========================================
+ Hits 15669 15672 +3
+ Misses 1152 1150 -2
+ Partials 296 295 -1 ☔ View full report in Codecov by Sentry. |
dmitryax
force-pushed
the
simlify-queue
branch
from
eff9c31
to
c4e02be
Compare
sfc-gh-bdrutu
approved these changes
Nov 22, 2023
bogdandrutu
approved these changes
Nov 22, 2023
Remove the QueueRequest wrapper. Pass consumeFunc to the queue instead of asking for the QueueRequest wrapper with callback. The callback isn't needed for the memory queue, and the field for the callback is occupying the memory even it's always empty. The bounded queue benchmark results shows the RAM savings: Before: ``` Benchmark_QueueUsage_50000_1_50000 Benchmark_QueueUsage_50000_1_50000-10 1 69813548417 ns/op 2806232 B/op 99753 allocs/op ``` After: ``` Benchmark_QueueUsage_50000_1_50000 Benchmark_QueueUsage_50000_1_50000-10 1 65498055709 ns/op 2404832 B/op 99754 allocs/op ```
dmitryax
force-pushed
the
simlify-queue
branch
from
c4e02be
to
cc775f6
Compare
pantuza
pushed a commit
to pantuza/opentelemetry-collector
that referenced
this pull request
Dec 8, 2023
…etry#8982) Remove the QueueRequest wrapper. Pass consumeFunc to the queue instead of asking for the QueueRequest wrapper with callback. The callback isn't needed for the memory queue, and the field for the callback is occupying the memory even it's always empty. The bounded queue benchmark results show the RAM savings: Before: ``` Benchmark_QueueUsage_50000_1_50000 Benchmark_QueueUsage_50000_1_50000-10 1 69813548417 ns/op 2806232 B/op 99753 allocs/op ``` After: ``` Benchmark_QueueUsage_50000_1_50000 Benchmark_QueueUsage_50000_1_50000-10 1 65498055709 ns/op 2404832 B/op 99754 allocs/op ``` Cut from open-telemetry#8942
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the QueueRequest wrapper. Pass consumeFunc to the queue instead of asking for the QueueRequest wrapper with callback. The callback isn't needed for the memory queue, and the field for the callback is occupying the memory even it's always empty. The bounded queue benchmark results show the RAM savings:
Before:
After:
Cut from #8942