[chore] [exporterhelper] Remove retry sender -> queue sender callback #8942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8942 +/- ##
==========================================
- Coverage 91.55% 91.55% -0.01%
==========================================
Files 315 315
Lines 17117 17105 -12
==========================================
- Hits 15672 15660 -12
Misses 1150 1150
Partials 295 295 ☔ View full report in Codecov by Sentry. |
dmitryax
force-pushed
the
remove-retry-queue-callback
branch
6 times, most recently
from
ae14cff
to
c25c88e
Compare
dmitryax
force-pushed
the
remove-retry-queue-callback
branch
2 times, most recently
from
39c1e38
to
94a70c0
Compare
dmitryax
force-pushed
the
remove-retry-queue-callback
branch
from
94a70c0
to
df85077
Compare
|
The coverage will be improved after #8960 is merged |
|
This PR introduces a significant change in behavior: re-enqueueing in the persistent queue will be always enabled even if the retry sender is disabled. I'm turning it into a draft for now until it's properly addressed. |
bogdandrutu
pushed a commit
that referenced
this pull request
Nov 21, 2023
) Update the test validating failed re-enqueue to ensure that the request is sent through the queue sender, not the retry sender. It'll unblock removing the dependency on the retry sender for the re-enqueue as done in #8942
dmitryax
force-pushed
the
remove-retry-queue-callback
branch
from
df85077
to
82f55a4
Compare
This is now resolved by introducing a separate config option for re-enqueue. |
dmitryax
force-pushed
the
remove-retry-queue-callback
branch
2 times, most recently
from
2b3035d
to
9727f41
Compare
|
I'm going to break this PR down |
dmitryax
added a commit
that referenced
this pull request
Nov 22, 2023
Remove the QueueRequest wrapper. Pass consumeFunc to the queue instead of asking for the QueueRequest wrapper with callback. The callback isn't needed for the memory queue, and the field for the callback is occupying the memory even it's always empty. The bounded queue benchmark results show the RAM savings: Before: ``` Benchmark_QueueUsage_50000_1_50000 Benchmark_QueueUsage_50000_1_50000-10 1 69813548417 ns/op 2806232 B/op 99753 allocs/op ``` After: ``` Benchmark_QueueUsage_50000_1_50000 Benchmark_QueueUsage_50000_1_50000-10 1 65498055709 ns/op 2404832 B/op 99754 allocs/op ``` Cut from #8942
This change changes the re-enqueue capability of the queue sender to not depend on the retry sender and have a separate configuration for that
dmitryax
force-pushed
the
remove-retry-queue-callback
branch
from
9727f41
to
d84c40a
Compare
|
Closing in favor of #8985 |
pantuza
pushed a commit
to pantuza/opentelemetry-collector
that referenced
this pull request
Dec 8, 2023
…en-telemetry#8960) Update the test validating failed re-enqueue to ensure that the request is sent through the queue sender, not the retry sender. It'll unblock removing the dependency on the retry sender for the re-enqueue as done in open-telemetry#8942
pantuza
pushed a commit
to pantuza/opentelemetry-collector
that referenced
this pull request
Dec 8, 2023
…etry#8982) Remove the QueueRequest wrapper. Pass consumeFunc to the queue instead of asking for the QueueRequest wrapper with callback. The callback isn't needed for the memory queue, and the field for the callback is occupying the memory even it's always empty. The bounded queue benchmark results show the RAM savings: Before: ``` Benchmark_QueueUsage_50000_1_50000 Benchmark_QueueUsage_50000_1_50000-10 1 69813548417 ns/op 2806232 B/op 99753 allocs/op ``` After: ``` Benchmark_QueueUsage_50000_1_50000 Benchmark_QueueUsage_50000_1_50000-10 1 65498055709 ns/op 2404832 B/op 99754 allocs/op ``` Cut from open-telemetry#8942
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use returned error instead to simplify the senders feedback loop