[chore] [exporterhelper] Remove retry sender -> queue sender callback #8985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
just-remove-retry-callback
branch
from
c191421
to
70df458
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8985 +/- ##
==========================================
- Coverage 91.55% 91.55% -0.01%
==========================================
Files 315 315
Lines 17117 17113 -4
==========================================
- Hits 15672 15668 -4
Misses 1150 1150
Partials 295 295 ☔ View full report in Codecov by Sentry. |
dmitryax
force-pushed
the
just-remove-retry-callback
branch
from
70df458
to
6895ec1
Compare
Use returned error instead to simplify the senders feedback loop. This change preserves the behavior. Re-enqueueing of the temporary failures depend on enabled retry sender. This will be changed in the next step when re-queueing becomes a configurable option
dmitryax
force-pushed
the
just-remove-retry-callback
branch
from
6895ec1
to
80531cc
Compare
bogdandrutu
approved these changes
Nov 26, 2023
Comment on lines
+179
to
+187
| // If retry sender is disabled then disable requeuing in the queue sender. | ||
| // TODO: Make re-enqueuing configurable on queue sender instead of relying on retry sender. | ||
| if qs, ok := be.queueSender.(*queueSender); ok { | ||
| // if it's not retrySender, then it is disabled. | ||
| if _, ok = be.retrySender.(*retrySender); !ok { | ||
| qs.requeuingEnabled = false | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I am not sure that this was intentional or a bug of the previous implementation. Happy to keep it as it is now, but my bet is that it was just a bug in the previous implementation.
There was a problem hiding this comment.
Even if it's a bug, I believe some users may rely on this behavior. Fixing it right away by removing the dependency would be a breaking change for those who don't want re-enqueueing in the persistent queue. I submitted an issue to introduce an explicit option to control it #8987. Will handle it next
dmitryax
added a commit
to dmitryax/opentelemetry-collector
that referenced
this pull request
Nov 27, 2023
After open-telemetry#8985, the whole request is requeued even with the partial request error. This change fixes it and restores the previous behavior. No changelog is needed since the bug is not released yet.
pantuza
pushed a commit
to pantuza/opentelemetry-collector
that referenced
this pull request
Dec 8, 2023
…open-telemetry#8985) Use returned error instead to simplify the senders feedback loop. This change preserves the behavior. Re-enqueueing of the temporary failures depends on the enabled retry sender. This will be changed in the next step when re-queueing becomes a configurable option
pantuza
pushed a commit
to pantuza/opentelemetry-collector
that referenced
this pull request
Dec 8, 2023
…pen-telemetry#8992) After open-telemetry#8985, the whole request is requeued even with the partial request error. This change fixes it and restores the previous behavior. No changelog is needed since the bug is not released yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use returned error instead to simplify the senders feedback loop. This change preserves the behavior. Re-enqueueing of the temporary failures depends on the enabled retry sender. This will be changed in the next step when re-queueing becomes a configurable option