Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mdatagen] copy files from contrib to core #9172

Merged
merged 10 commits into from
Dec 22, 2023

Conversation

codeboten
Copy link
Contributor

This is to allow us to use it in core as well

This is to allow us to use it in core as well

Signed-off-by: Alex Boten <aboten@lightstep.com>
@codeboten codeboten requested review from a team and mx-psi December 21, 2023 23:10
Alex Boten added 2 commits December 21, 2023 15:12
Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 240 lines in your changes are missing coverage. Please review.

Comparison is base (1c84578) 91.39% compared to head (bccb66b) 90.54%.

Files Patch % Lines
cmd/mdatagen/main.go 43.06% 95 Missing and 24 partials ⚠️
cmd/mdatagen/loader.go 54.54% 60 Missing and 5 partials ⚠️
...md/mdatagen/internal/metadata/generated_metrics.go 90.61% 23 Missing ⚠️
cmd/mdatagen/metricdata.go 80.30% 12 Missing and 1 partial ⚠️
cmd/mdatagen/internal/metadata/generated_config.go 82.08% 8 Missing and 4 partials ⚠️
...d/mdatagen/internal/metadata/generated_resource.go 91.11% 4 Missing ⚠️
cmd/mdatagen/internal/metadata/generated_status.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9172      +/-   ##
==========================================
- Coverage   91.39%   90.54%   -0.86%     
==========================================
  Files         320      330      +10     
  Lines       17208    18195     +987     
==========================================
+ Hits        15728    16475     +747     
- Misses       1177     1383     +206     
- Partials      303      337      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hughesjj
Copy link

Super happy/excited with this change, and LGTM

Alex Boten added 2 commits December 21, 2023 15:43
Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
Alex Boten added 3 commits December 21, 2023 16:25
Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be at https://github.com/open-telemetry/opentelemetry-go-build-tools instead?

Seems no because of dependency issue. (mdatagen depends on core while core depends on build-tools)

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave it here then :) AFAICT the dependency is just on the autogenerated code used for testing, which we could split off into a separate module to avoid a circular module dependency, but no need to do this now

Alex Boten added 2 commits December 22, 2023 07:58
Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
@codeboten codeboten merged commit 4b340ca into open-telemetry:main Dec 22, 2023
31 of 32 checks passed
@codeboten codeboten deleted the codeboten/mdatagen branch December 22, 2023 16:18
@github-actions github-actions bot added this to the next release milestone Dec 22, 2023
bogdandrutu pushed a commit that referenced this pull request Dec 22, 2023
Follows
#9172

Signed-off-by: Alex Boten <aboten@lightstep.com>
bogdandrutu pushed a commit that referenced this pull request Dec 22, 2023
Follows
#9172

Signed-off-by: Alex Boten <aboten@lightstep.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants