[confignet] added NewDefaultFunctions #9671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sanket-0510
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9671 +/- ##
==========================================
- Coverage 90.98% 90.95% -0.03%
==========================================
Files 349 349
Lines 18572 18582 +10
==========================================
+ Hits 16897 16902 +5
- Misses 1348 1352 +4
- Partials 327 328 +1 ☔ View full report in Codecov by Sentry. |
…er default values of Endpoint and the DialerConfig
…tent and to the point
Sanket-0510
force-pushed
the
confignet-new-default
branch
from
093a842
to
16f6b10
Compare
andrzej-stencel
approved these changes
Mar 11, 2024
TylerHelmuth
approved these changes
Mar 11, 2024
TylerHelmuth
added
the
ready-to-merge
dmitryax
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added newDefault methods for structs in confignet package
Link to tracking Issue:
closes #9656
Testing: Tests were added for the newDefault functions
Documentation:
godoc