Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[configgrpc] Add NewDefault* functions for all config structs #9654

Closed
Tracked by #9508
TylerHelmuth opened this issue Feb 28, 2024 · 5 comments · Fixed by #9969
Closed
Tracked by #9508

[configgrpc] Add NewDefault* functions for all config structs #9654

TylerHelmuth opened this issue Feb 28, 2024 · 5 comments · Fixed by #9969
Assignees
@AkhigbeEromo
Labels
area:config good first issue Good for newcomers
Milestone
go.opentelemetry....

Comments

@TylerHelmuth
Copy link
Member

No description provided.

@TylerHelmuth TylerHelmuth mentioned this issue Feb 28, 2024
Closed
6 tasks
@Sanket-0510
Copy link
Contributor

I am working on this!

@AkhigbeEromo
Copy link
Contributor

Hey @Sanket-0510 are you still working over this ?

@Sanket-0510
Copy link
Contributor

Hey @Sanket-0510 are you still working over this ?

Actually I am having exams currently so I may not be able to work on this 😅 feel free to take this also you can refer my Other PR for refference #9671

@TylerHelmuth TylerHelmuth added help wanted Good issue for contributors to OpenTelemetry Service to pick up good first issue Good for newcomers labels Mar 22, 2024
@AkhigbeEromo
Copy link
Contributor

Can this be assigned to me? @TylerHelmuth

@AkhigbeEromo AkhigbeEromo mentioned this issue Mar 22, 2024
Closed
@AkhigbeEromo
Copy link
Contributor

Just created a pull request concerning this issue : #9819

@TylerHelmuth TylerHelmuth removed the help wanted Good issue for contributors to OpenTelemetry Service to pick up label Mar 22, 2024
@AkhigbeEromo AkhigbeEromo mentioned this issue Apr 15, 2024
Merged
codeboten added a commit that referenced this issue Apr 26, 2024
@AkhigbeEromo @TylerHelmuth @codeboten
Added default funcs for configgrpc (#9969)
1a5da25 
Description:
Added newDefault methods for structs in configgrpc package

Closes #9654

Testing: Tests were added for the NewDefault functions

---------

Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AkhigbeEromo AkhigbeEromo

Labels
area:config good first issue Good for newcomers
Projects
Collector: v1
Status: Done
Milestone
go.opentelemetry.io/collector/config/...
3 participants
@TylerHelmuth @Sanket-0510 @AkhigbeEromo