Added default funcs for configgrpc #9969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @TylerHelmuth, just corrected it |
|
the PR that creates a newDefault function for |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9969 +/- ##
==========================================
+ Coverage 91.56% 91.57% +0.01%
==========================================
Files 360 360
Lines 16698 16719 +21
==========================================
+ Hits 15289 15310 +21
Misses 1073 1073
Partials 336 336 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
@AkhigbeEromo please add default functions for KeepaliveServerParameters and KeepaliveEnforcementPolicy and corresponding tests
|
Sorry i missed that @TylerHelmuth |
Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
|
Hello @TylerHelmuth is there any other thing you would like me to add? |
TylerHelmuth
approved these changes
Apr 25, 2024
codeboten
reviewed
Apr 26, 2024
Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
andrzej-stencel
pushed a commit
to andrzej-stencel/opentelemetry-collector
that referenced
this pull request
May 27, 2024
Description: Added newDefault methods for structs in configgrpc package Closes open-telemetry#9654 Testing: Tests were added for the NewDefault functions --------- Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com> Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added newDefault methods for structs in configgrpc package
Link to tracking Issue:
Closes #9654
Testing: Tests were added for the NewDefault functions