Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Populate the net.peer.ip and net.peer.port atttributes #73

Merged
merged 3 commits into from
Nov 25, 2021
Merged

Populate the net.peer.ip and net.peer.port atttributes #73

merged 3 commits into from
Nov 25, 2021

Conversation

tobiasstadler
Copy link
Member

No description provided.

@tobiasstadler tobiasstadler requested a review from a team November 24, 2021 15:07
seemk
seemk approved these changes Nov 25, 2021
View reviewed changes
Copy link
Contributor

@seemk seemk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Perhaps we should also check for the shape of the attribute? Added my suggestions 🙂

instrumentation/nginx/test/instrumentation/test/instrumentation_test.exs Outdated Show resolved Hide resolved
instrumentation/nginx/test/instrumentation/test/instrumentation_test.exs Outdated Show resolved Hide resolved
@seemk seemk merged commit 9b01f8c into open-telemetry:main Nov 25, 2021
@tobiasstadler tobiasstadler deleted the net.peer branch November 25, 2021 09:07
@tobiasstadler
Copy link
Member Author

Thank You!

@tobiasstadler tobiasstadler mentioned this pull request May 4, 2022
Closed
6 tasks
@marcalff marcalff added the instrumentation:nginx Nginx module label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seemk seemk seemk approved these changes

Assignees
No one assigned
Labels
instrumentation:nginx Nginx module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tobiasstadler @seemk @marcalff