Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the Google naming convention. #12

Merged
merged 2 commits into from
Nov 11, 2019
Merged

Conversation

g-easy
Copy link
Contributor

@g-easy g-easy commented Nov 5, 2019

Part of #5.

@g-easy
Copy link
Contributor Author

g-easy commented Nov 5, 2019

We discussed this during today's SIG meeting.

@rnburn
Copy link
Contributor

rnburn commented Nov 5, 2019

Can change this to refer just to the Google naming convention, not the full style guide?

What I though we agreed to was core guidelines for the style guide and the google naming convention (since core guidelines doesn't have one)

@g-easy
Copy link
Contributor Author

g-easy commented Nov 5, 2019

@rnburn I'd like to apply most of the style guide, e.g. Output Parameters. How should I change the wording?

Also, we should document exceptions like:

  • API should not use features newer than C++11.
  • API must be header only.
  • Don't use STL types in the API.

@rnburn
Copy link
Contributor

rnburn commented Nov 5, 2019

Can we limit this PR to just what we agreed to on the call (which was the naming convention)?

Maybe don't use it to close #5 if you want to further debate the non-naming parts of a style guide.

I would prefer to take CppCore guideline over Google style guide for other parts (they use references for Output parameters).

@g-easy g-easy changed the title Use the Google C++ style guide. Use the Google naming convention. Nov 5, 2019
@g-easy
Copy link
Contributor Author

g-easy commented Nov 5, 2019

Ah, ok. I've updated the PR. Not closing #5.

@g-easy
Copy link
Contributor Author

g-easy commented Nov 5, 2019

Please remind me: how many approvals do I need before it's okay to merge? :)

@reyang
Copy link
Member

reyang commented Nov 5, 2019

Please remind me: how many approvals do I need before it's okay to merge? :)

https://github.com/open-telemetry/opentelemetry-cpp/blob/master/CONTRIBUTING.md#how-to-get-prs-merged

@reyang reyang merged commit c696ca4 into open-telemetry:master Nov 11, 2019
@g-easy g-easy deleted the style branch December 17, 2019 05:06
0x4b pushed a commit to 0x4b/opentelemetry-cpp that referenced this pull request Aug 19, 2020
GerHobbelt pushed a commit to GerHobbelt/opentelemetry-cpp that referenced this pull request Jun 21, 2024
[DOC] Fix OTLP documentation: Default endpoint is wrong for OTLP/HTTP…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants