Start documenting requirements. #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-easy
requested review from
jmacd,
maxgolov,
reyang,
rnburn and
tigrannajaryan
as code owners
|
This is a starting point and is based on the discussion we had in today's meeting. |
jmacd
approved these changes
Dec 17, 2019
rnburn
reviewed
Dec 17, 2019
|
|
||
| This also requires a stable C++ ABI. There is quite a bit of interest in this. | ||
|
|
||
| This means STL types can't be used in the interface. |
There was a problem hiding this comment.
Or only STL types with well defined ABIs (e.g. std::array, std::pair)
There was a problem hiding this comment.
I'm a little bit worried because e.g. libc++ and absl can't even agree on string_view. :)
I would prefer nostd::span (i.e. array_view) over std::array.
As for pair IDK. Are you sure it won't cause a problem in future?
rnburn
approved these changes
Dec 17, 2019
0x4b
pushed a commit
to 0x4b/opentelemetry-cpp
that referenced
this pull request
Aug 19, 2020
GerHobbelt
pushed a commit
to GerHobbelt/opentelemetry-cpp
that referenced
this pull request
Jun 21, 2024
[BUILD] update vcpkg submodule to 20240214 (open-telemetry#2575)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #4.