Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Old Metrics Cleanup] Remove old metric from GitHub CI #1733

Merged
merged 2 commits into from
Nov 5, 2022

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Nov 4, 2022

Changes

This does cleanup of first part of #1573 - Removing old metrics build/tests from GitHub CI

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@lalitb lalitb requested a review from a team November 4, 2022 23:18
@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Merging #1733 (5f8e89a) into main (7634edf) will decrease coverage by 0.06%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1733      +/-   ##
==========================================
- Coverage   85.79%   85.73%   -0.05%     
==========================================
  Files         171      171              
  Lines        5212     5212              
==========================================
- Hits         4471     4468       -3     
- Misses        741      744       +3     
Impacted Files Coverage Δ
ext/src/http/client/curl/http_client_curl.cc 80.31% <0.00%> (-1.13%) ⬇️

Copy link
Member

@esigo esigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for the PR.

Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@esigo esigo merged commit 99a9b4c into open-telemetry:main Nov 5, 2022
yxue pushed a commit to yxue/opentelemetry-cpp that referenced this pull request Dec 5, 2022
yxue pushed a commit to yxue/opentelemetry-cpp that referenced this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants