Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] Bump abseil-cpp for cmake CI #1807

Merged
merged 2 commits into from
Nov 27, 2022
Merged

[BUILD] Bump abseil-cpp for cmake CI #1807

merged 2 commits into from
Nov 27, 2022

Conversation

esigo
Copy link
Member

@esigo esigo commented Nov 25, 2022

Bump abseil-cpp for cmake CI

Changes

from 20210324.0 to 20220623.1
also fixes gRPC version in third_party_release

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@esigo esigo requested a review from a team November 25, 2022 20:15
@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Merging #1807 (01ff0a0) into main (5642d1c) will increase coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1807      +/-   ##
==========================================
+ Coverage   85.73%   85.77%   +0.04%     
==========================================
  Files         171      171              
  Lines        5240     5240              
==========================================
+ Hits         4492     4494       +2     
+ Misses        748      746       -2     
Impacted Files Coverage Δ
sdk/src/trace/batch_span_processor.cc 90.63% <0.00%> (-0.78%) ⬇️
ext/src/http/client/curl/http_client_curl.cc 81.44% <0.00%> (+1.14%) ⬆️

@esigo esigo changed the title Bump abseil-cpp for cmake CI [BUILD] Bump abseil-cpp for cmake CI Nov 25, 2022
@esigo esigo added the size:small 1-2 days label Nov 26, 2022
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good. We can also add the cmake CI test for macOS to validate if the changes work, probably as separate PR if it can't be added here :)

@esigo
Copy link
Member Author

esigo commented Nov 27, 2022

Thanks, this looks good. We can also add the cmake CI test for macOS to validate if the changes work, probably as separate PR if it can't be added here :)

@lalitb let's add the CI in another PR.

@esigo esigo merged commit 0122b13 into open-telemetry:main Nov 27, 2022
@esigo esigo deleted the absl branch November 27, 2022 09:54
yxue pushed a commit to yxue/opentelemetry-cpp that referenced this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants