Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OTELCPP_MAINTAINER_MODE #1844

Merged
merged 6 commits into from
Dec 9, 2022
Merged

Fix OTELCPP_MAINTAINER_MODE #1844

merged 6 commits into from
Dec 9, 2022

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Dec 5, 2022 •
edited
Loading

Fix OTELCPP_MAINTAINER_MODE

Changes

Fix OTELCPP_MAINTAINER_MODE

  • bump gcc to version 12
  • bump clang to version 14
  • bump googletest to 1.12.1 (1.10 causes new build warnings with upgraded gcc and clang)
  • expand coverage on W3C tests
  • fix new warnings reported
  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff
fix MAINTAINER_MODE:
6eb1001 
- bump gcc to version 12
- bump clang to version 14
- expand coverage on W3C tests
@marcalff marcalff requested a review from a team December 5, 2022 22:17
@codecov
Copy link

codecov bot commented Dec 5, 2022 •
edited
Loading

Codecov Report

Merging #1844 (fd88a5d) into main (722ad4e) will decrease coverage by 0.06%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1844      +/-   ##
==========================================
- Coverage   85.79%   85.73%   -0.05%     
==========================================
  Files         171      171              
  Lines        5240     5240              
==========================================
- Hits         4495     4492       -3     
- Misses        745      748       +3
Impacted Files Coverage Δ
api/include/opentelemetry/nostd/span.h 90.00% <ø> (ø)
ext/src/http/client/curl/http_client_curl.cc 80.31% <0.00%> (-1.13%) ⬇️

@marcalff marcalff changed the title Fix MAINTAINER_MODE [Cleanup in progress] Fix MAINTAINER_MODE Dec 5, 2022
@marcalff marcalff changed the title [Cleanup in progress] Fix MAINTAINER_MODE Fix MAINTAINER_MODE Dec 6, 2022
@marcalff marcalff changed the title Fix MAINTAINER_MODE Fix OTELCPP_MAINTAINER_MODE Dec 6, 2022
lalitb
lalitb approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@marcalff marcalff mentioned this pull request Dec 8, 2022
Closed
owent
owent approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@owent owent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

owent added a commit to owent/opentelemetry-cpp that referenced this pull request Dec 8, 2022
@owent
Merge partly of open-telemetry#1844
aa64410 
Signed-off-by: owent <admin@owent.net>
owent added a commit to owent/opentelemetry-cpp that referenced this pull request Dec 8, 2022
@owent
Update third_party/opentelemetry-proto
f9693d1 
Signed-off-by: owent <admin@owent.net>
Merge partly of open-telemetry#1844

Signed-off-by: owent <admin@owent.net>

Update gtest to 1.12.1 by default

Signed-off-by: owent <admin@owent.net>
Fix compatibility when using clang and libc++

Signed-off-by: owent <admin@owent.net>
owent added a commit to owent/opentelemetry-cpp that referenced this pull request Dec 9, 2022
@owent
Update third_party/opentelemetry-proto
441dfd7 
Signed-off-by: owent <admin@owent.net>
Merge partly of open-telemetry#1844

Signed-off-by: owent <admin@owent.net>

Update gtest to 1.12.1 by default

Signed-off-by: owent <admin@owent.net>
Fix compatibility when using clang and libc++

Signed-off-by: owent <admin@owent.net>
@owent owent mentioned this pull request Dec 9, 2022
Merged
3 tasks
@marcalff marcalff added the pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.) label Dec 9, 2022
@lalitb lalitb merged commit 75f3900 into open-telemetry:main Dec 9, 2022
owent added a commit to owent/opentelemetry-cpp that referenced this pull request Dec 12, 2022
@owent
Update third_party/opentelemetry-proto
3b9183e 
Signed-off-by: owent <admin@owent.net>
Merge partly of open-telemetry#1844

Signed-off-by: owent <admin@owent.net>

Update gtest to 1.12.1 by default

Signed-off-by: owent <admin@owent.net>
Fix compatibility when using clang and libc++

Signed-off-by: owent <admin@owent.net>

No need build local gtest when using legacy toolchain.

Signed-off-by: owent <admin@owent.net>

Fix env in sudo

Signed-off-by: owent <admin@owent.net>

Add hint to print current C++ standard and stdlib for cmake.

Signed-off-by: owent <admin@owent.net>

Print output of C++ environment detection

Signed-off-by: owent <admin@owent.net>

Allow to set cxx flags by environments in CI jobs.

Signed-off-by: owent <admin@owent.net>

fix MAINTAINER_MODE:
- bump gcc to version 12
- bump clang to version 14
- expand coverage on W3C tests

Upgrade gootletest 1.12.1

Fixed new warnings.

Fixed format, added changelog.

Using fallback version of span when `std::span` do not support `range`.

Signed-off-by: owent <admin@owent.net>
owent added a commit to owent/opentelemetry-cpp that referenced this pull request Dec 13, 2022
@owent
Update third_party/opentelemetry-proto
96e63a2 
Signed-off-by: owent <admin@owent.net>
Merge partly of open-telemetry#1844

Signed-off-by: owent <admin@owent.net>

Update gtest to 1.12.1 by default

Signed-off-by: owent <admin@owent.net>
Fix compatibility when using clang and libc++

Signed-off-by: owent <admin@owent.net>

No need build local gtest when using legacy toolchain.

Signed-off-by: owent <admin@owent.net>

Fix env in sudo

Signed-off-by: owent <admin@owent.net>

Add hint to print current C++ standard and stdlib for cmake.

Signed-off-by: owent <admin@owent.net>

Print output of C++ environment detection

Signed-off-by: owent <admin@owent.net>

Allow to set cxx flags by environments in CI jobs.

Signed-off-by: owent <admin@owent.net>

fix MAINTAINER_MODE:
- bump gcc to version 12
- bump clang to version 14
- expand coverage on W3C tests

Upgrade gootletest 1.12.1

Fixed new warnings.

Fixed format, added changelog.

Using fallback version of span when `std::span` do not support `range`.

Signed-off-by: owent <admin@owent.net>
@marcalff marcalff deleted the fix_maintainer_mode_compiler branch July 4, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomsonTan ThomsonTan ThomsonTan left review comments

@lalitb lalitb lalitb approved these changes

@owent owent owent approved these changes

Assignees
No one assigned
Labels
pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marcalff @ThomsonTan @lalitb @owent