Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Frontend Service - GoLang #108

Merged
merged 2 commits into from
Jun 7, 2022
Merged

Update Frontend Service - GoLang #108

merged 2 commits into from
Jun 7, 2022

Conversation

mic-max
Copy link
Contributor

@mic-max mic-max commented Jun 4, 2022

Changes

  • Replace generated Go files with them being built in Dockerfile
  • Timestamp.proto was also added in another PR - need to find a way around issue to remove it later
  • Force FRONTEND_ADDR env var to be defined
  • Multiple changes akin to this one
    image

@mic-max mic-max requested a review from a team as a code owner June 4, 2022 00:07
@mic-max mic-max mentioned this pull request Jun 6, 2022
Merged
@mic-max mic-max mentioned this pull request Jun 7, 2022
Open
@mic-max @julianocosta89
Fix footer link
4f1a515 
Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
julianocosta89
julianocosta89 approved these changes Jun 7, 2022
View reviewed changes
Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cartersocha cartersocha merged commit a6b6abb into open-telemetry:main Jun 7, 2022
@cartersocha
Copy link
Contributor

Wow nice ratio

@mic-max mic-max deleted the frontend-proto-update branch June 7, 2022 23:10
GaryPWhite pushed a commit to wayfair-contribs/opentelemetry-demo that referenced this pull request Jun 30, 2022
@mic-max @GaryPWhite
Update Frontend Service - GoLang (open-telemetry#108)
5c57ead
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
@mic-max
Update Frontend Service - GoLang (open-telemetry#108)
cb93f00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianocosta89 julianocosta89 julianocosta89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mic-max @cartersocha @julianocosta89