Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Proto Files for Checkout Service - GoLang #116

Merged
merged 2 commits into from
Jun 14, 2022
Merged

Generate Proto Files for Checkout Service - GoLang #116

merged 2 commits into from
Jun 14, 2022

Conversation

mic-max
Copy link
Contributor

@mic-max mic-max commented Jun 6, 2022

Changes

  • Replace generated Go files with them being built in Dockerfile
  • Force CHECKOUT_SERVICE_PORT env var to be defined

Very similar changes to #108

@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jun 14, 2022
@mic-max mic-max changed the title Update Checkout Service - GoLang Generate Proto Files for Checkout Service - GoLang Jun 14, 2022
@cartersocha cartersocha merged commit a1d1d73 into open-telemetry:main Jun 14, 2022
@mic-max mic-max deleted the checkout-update branch June 20, 2022 18:15
GaryPWhite pushed a commit to wayfair-contribs/opentelemetry-demo that referenced this pull request Jun 30, 2022
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants