Add logs for Ad service and Recommendation service #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enable logs for Ad service and Recommendation service. - Add OTLP exporters for logs - Add the filter processor to prevent an error from the Prometheus exporter for duplicate queueSize metric, see open-telemetry/opentelemetry-collector-contrib#18194. The filter processor can be removed when the fault gets fixed. This PR doesn’t introduce any logs backend. Instead, logs are output only to Logging exporter and can be seen in the console (otelcol). otel-col | 2023-03-17T11:40:22.662Z info LogsExporter {"kind": "exporter", "data_type": "logs", "name": "logging", "#logs": 2} After this PR, different logging backends can be easily tested by configuring an additional exporter.
julianocosta89
added
the
helm-update-required
2 tasks
julianocosta89
approved these changes
Mar 17, 2023
There was a problem hiding this comment.
LGTM!
We also need to add that to the docs.
I've created the following issue: open-telemetry/opentelemetry.io#2521
austinlparker
approved these changes
Mar 20, 2023
juliangiuca
pushed a commit
to juliangiuca/opentelemetry-demo
that referenced
this pull request
Apr 12, 2023
* What’s included? - Enable logs for Ad service and Recommendation service. - Add OTLP exporters for logs - Add the filter processor to prevent an error from the Prometheus exporter for duplicate queueSize metric, see open-telemetry/opentelemetry-collector-contrib#18194. The filter processor can be removed when the fault gets fixed. This PR doesn’t introduce any logs backend. Instead, logs are output only to Logging exporter and can be seen in the console (otelcol). otel-col | 2023-03-17T11:40:22.662Z info LogsExporter {"kind": "exporter", "data_type": "logs", "name": "logging", "#logs": 2} After this PR, different logging backends can be easily tested by configuring an additional exporter. * Add changelog and fix lint errors. * Fix changelog and lint * Fix lint * Move protocol env variables to .env * Update CHANGELOG.md --------- Co-authored-by: Austin Parker <austin@ap2.io> Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
* What’s included? - Enable logs for Ad service and Recommendation service. - Add OTLP exporters for logs - Add the filter processor to prevent an error from the Prometheus exporter for duplicate queueSize metric, see open-telemetry/opentelemetry-collector-contrib#18194. The filter processor can be removed when the fault gets fixed. This PR doesn’t introduce any logs backend. Instead, logs are output only to Logging exporter and can be seen in the console (otelcol). otel-col | 2023-03-17T11:40:22.662Z info LogsExporter {"kind": "exporter", "data_type": "logs", "name": "logging", "#logs": 2} After this PR, different logging backends can be easily tested by configuring an additional exporter. * Add changelog and fix lint errors. * Fix changelog and lint * Fix lint * Move protocol env variables to .env * Update CHANGELOG.md --------- Co-authored-by: Austin Parker <austin@ap2.io> Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What’s included?
This PR doesn’t introduce any logs backend. Instead, logs are output only to Logging exporter and can be seen in the console (otelcol).
otel-col | 2023-03-17T11:40:22.662Z info LogsExporter {"kind": "exporter", "data_type": "logs", "name": "logging", "#logs": 2}After this PR, different logging backends can be easily tested by configuring additional exporters.
CHANGELOG.mdupdated to document new feature additions