Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Exporter.Geneva] Fix serialization issue when there are no exemplars #1099

Merged
merged 2 commits into from
Mar 23, 2023
Merged

[Exporter.Geneva] Fix serialization issue when there are no exemplars #1099

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5da306f
Fix serialization
utpilla Mar 23, 2023
f4fa7e9
Merge branch 'main' into utpilla/Fix-GenevaMetricExporter-Serialization
utpilla Mar 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions src/OpenTelemetry.Exporter.Geneva/Metrics/GenevaMetricExporter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -612,6 +612,7 @@ internal unsafe ushort SerializeMetricWithTLV(

MetricSerializer.SerializeByte(this.buffer, ref bufferIndex, 0); // version

// TODO: Avoid this additional enumeration
var exemplarsCount = 0;
foreach (var exemplar in exemplars)
{
Expand All @@ -630,10 +631,10 @@ internal unsafe ushort SerializeMetricWithTLV(
this.SerializeExemplar(exemplar, ref bufferIndex);
}
}
}

payloadTypeLength = (ushort)(bufferIndex - payloadTypeStartIndex - 2);
MetricSerializer.SerializeUInt16(this.buffer, ref payloadTypeStartIndex, payloadTypeLength);
payloadTypeLength = (ushort)(bufferIndex - payloadTypeStartIndex - 2);
MetricSerializer.SerializeUInt16(this.buffer, ref payloadTypeStartIndex, payloadTypeLength);
}

#endregion

Expand Down Expand Up @@ -817,6 +818,7 @@ internal unsafe ushort SerializeHistogramMetricWithTLV(

MetricSerializer.SerializeByte(this.buffer, ref bufferIndex, 0); // version

// TODO: Avoid this additional enumeration
var exemplarsCount = 0;
foreach (var exemplar in exemplars)
{
Expand All @@ -835,10 +837,10 @@ internal unsafe ushort SerializeHistogramMetricWithTLV(
this.SerializeExemplar(exemplar, ref bufferIndex);
}
}
}

payloadTypeLength = (ushort)(bufferIndex - payloadTypeStartIndex - 2);
MetricSerializer.SerializeUInt16(this.buffer, ref payloadTypeStartIndex, payloadTypeLength);
payloadTypeLength = (ushort)(bufferIndex - payloadTypeStartIndex - 2);
MetricSerializer.SerializeUInt16(this.buffer, ref payloadTypeStartIndex, payloadTypeLength);
}

#endregion

Expand Down Expand Up @@ -913,7 +915,7 @@ private void SerializeExemplar(Exemplar exemplar, ref int bufferIndex)

var flags = ExemplarFlags.IsTimestampAvailable; // we only serialize exemplars with Timestamp != default

// TODO: Update the code whenn Exemplars support long values
// TODO: Update the code when Exemplars support long values
var value = exemplar.DoubleValue;

// Check if the double value is actually a whole number that can be serialized as a long instead
Expand Down
Loading