Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indexing issue in GetSanitizedCategoryName #1175

Merged
merged 1 commit into from
May 9, 2023

Conversation

dariusclay
Copy link
Contributor

Small trivial update. Fixes #1174.

Changes

Change variable used to index result string.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@dariusclay dariusclay requested a review from a team as a code owner May 9, 2023 10:21
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 9, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: dariusclay / name: Darius Letterman (fcb5ef8)

@Kielek Kielek added the comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva label May 9, 2023
@Kielek
Copy link
Contributor

Kielek commented May 9, 2023

@dariusclay, is it worth to add some test to cover this scenario? Just to prevent regression.

@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #1175 (fcb5ef8) into main (71a7216) will not change coverage.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1175   +/-   ##
=======================================
  Coverage   72.81%   72.81%           
=======================================
  Files         244      244           
  Lines        8787     8787           
=======================================
  Hits         6398     6398           
  Misses       2389     2389           
Impacted Files Coverage Δ
...etry.Exporter.Geneva/TLDExporter/TldLogExporter.cs 37.11% <0.00%> (ø)

@utpilla
Copy link
Contributor

utpilla commented May 9, 2023

@dariusclay Thanks for creating this PR!

@utpilla utpilla merged commit d050f98 into open-telemetry:main May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TldLogExporter event name sanitization issues
7 participants