-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for abstract domain sockets in OpenTelemetry.Exporter.Geneva #1199
add support for abstract domain sockets in OpenTelemetry.Exporter.Geneva #1199
Conversation
|
src/OpenTelemetry.Exporter.Geneva/Internal/ConnectionStringBuilder.cs
Outdated
Show resolved
Hide resolved
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
…emetry-dotnet-contrib into abstract-domain-sockets
src/OpenTelemetry.Exporter.Geneva/Internal/ConnectionStringBuilder.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a changelog entry.
Co-authored-by: Reiley Yang <reyang@microsoft.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1199 +/- ##
==========================================
+ Coverage 73.17% 74.05% +0.88%
==========================================
Files 260 266 +6
Lines 9133 9340 +207
==========================================
+ Hits 6683 6917 +234
+ Misses 2450 2423 -27
|
There is an unrelated test failing: https://github.com/open-telemetry/opentelemetry-dotnet-contrib/actions/runs/5127460320/jobs/9224407051?pr=1199#step:7:213 |
Fixes #1198.
Changes
This allows
@
character represent the null byte used in the connection strings for abstract domain sockets.For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes