Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for abstract domain sockets in OpenTelemetry.Exporter.Geneva #1199

Merged
merged 13 commits into from
May 31, 2023

Conversation

cataggar
Copy link
Contributor

@cataggar cataggar commented May 20, 2023

Fixes #1198.

Changes

This allows @ character represent the null byte used in the connection strings for abstract domain sockets.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@cataggar cataggar requested a review from a team as a code owner May 20, 2023 10:04
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 20, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: cataggar / name: Cameron Taggart (0cad285)

@Kielek Kielek added the comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva label May 22, 2023
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label May 30, 2023
@cataggar cataggar requested a review from reyang May 30, 2023 09:17
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a changelog entry.

@reyang reyang removed the Stale label May 30, 2023
@utpilla
Copy link
Contributor

utpilla commented May 31, 2023

Thanks for this PR @cataggar ! I have pushed two minor changes related to CHANGELOG edits: 384549d and f3878fd.

@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Merging #1199 (a949b84) into main (18b0b03) will increase coverage by 0.88%.
The diff coverage is 97.57%.

❗ Current head a949b84 differs from pull request most recent head f3878fd. Consider uploading reports for the commit f3878fd to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1199      +/-   ##
==========================================
+ Coverage   73.17%   74.05%   +0.88%     
==========================================
  Files         260      266       +6     
  Lines        9133     9340     +207     
==========================================
+ Hits         6683     6917     +234     
+ Misses       2450     2423      -27     
Impacted Files Coverage Δ
src/OpenTelemetry.Sampler.AWS/Clock.cs 100.00% <ø> (ø)
...rs.AWS/Http/ServerCertificateValidationProvider.cs 59.67% <80.00%> (+0.30%) ⬆️
.../OpenTelemetry.Sampler.AWS/AWSXRayRemoteSampler.cs 82.60% <91.30%> (+10.86%) ⬆️
src/OpenTelemetry.Sampler.AWS/RulesCache.cs 90.90% <96.00%> (+17.83%) ⬆️
...xporter.Geneva/Internal/ConnectionStringBuilder.cs 92.94% <100.00%> (+0.25%) ⬆️
...ry.ResourceDetectors.AWS/AWSECSResourceDetector.cs 83.69% <100.00%> (ø)
...ry.ResourceDetectors.AWS/AWSEKSResourceDetector.cs 58.62% <100.00%> (ø)
...penTelemetry.ResourceDetectors.AWS/Http/Handler.cs 73.33% <100.00%> (+2.74%) ⬆️
.../OpenTelemetry.Sampler.AWS/AWSXRaySamplerClient.cs 96.61% <100.00%> (+8.51%) ⬆️
src/OpenTelemetry.Sampler.AWS/FallbackSampler.cs 100.00% <100.00%> (ø)
... and 9 more

... and 4 files with indirect coverage changes

@utpilla
Copy link
Contributor

utpilla commented May 31, 2023

@utpilla utpilla merged commit 81364e6 into open-telemetry:main May 31, 2023
@cataggar cataggar deleted the abstract-domain-sockets branch June 1, 2023 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add support for abstract domain sockets in OpenTelemetry.Exporter.Geneva
7 participants