Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow overriding the Part B "name" field value in GenevaLogExporter #1367

Merged
merged 6 commits into from
Sep 22, 2023
Merged

Allow overriding the Part B "name" field value in GenevaLogExporter #1367

merged 6 commits into from
Sep 22, 2023

Conversation

jdom
Copy link
Contributor

@jdom jdom commented Sep 21, 2023

Fixes #1186

Changes

Allow overriding the "name" field in the Geneva Log Exporter
This allows big codebases to be migrated to OpenTelemetry while still maintaining back-compatibility of the emitted logs

@jdom jdom requested a review from a team as a code owner September 21, 2023 17:55
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 21, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@jdom
Copy link
Contributor Author

jdom commented Sep 21, 2023

I can add test coverage / changelog. Just wanted to make sure this PR is something that can be considered, as the issue was closed as by design. But as you can see, this PR does not contradict Common Schema, it just enables a huge codebase to be migrated over to Open Telemetry

@jdom jdom changed the title Allow overriding the "name" field in the Geneva Log Exporter Allow overriding the Part B "name" field in the GenevaLogExporter Sep 21, 2023
@codecov
Copy link

codecov bot commented Sep 21, 2023 •
edited
Loading

Codecov Report

Merging #1367 (c76979a) into main (71655ce) will decrease coverage by 15.83%.
Report is 8 commits behind head on main.
The diff coverage is 47.05%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1367       +/-   ##
===========================================
- Coverage   73.91%   58.09%   -15.83%     
===========================================
  Files         267       29      -238     
  Lines        9615     3028     -6587     
===========================================
- Hits         7107     1759     -5348     
+ Misses       2508     1269     -1239
Flag Coverage Δ
unittests-Exporter.Geneva 58.09% <47.05%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage
...etry.Exporter.Geneva/TLDExporter/TldLogExporter.cs 0.00%
...orter.Geneva/MsgPackExporter/MsgPackLogExporter.cs 100.00%

@jdom
Better backwards compatibility when using customFields without specif…
36712f9 
…ying "name".

Only allow string values for "name"
Add test coverage
@jdom
Add changelog
e930417
reyang
reyang approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The direction and logic look good to me.

I'm slightly concerned about perf since we're adding more string comparisons in a loop (which all customers will have to pay for). But I think that's a separate issue which we should tackle outside of this PR.

@jdom jdom changed the title Allow overriding the Part B "name" field in the GenevaLogExporter Allow overriding the Part B "name" field value in GenevaLogExporter Sep 21, 2023
@Kielek Kielek added the comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva label Sep 22, 2023
CodeBlanch
CodeBlanch approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeBlanch CodeBlanch merged commit 5782da1 into open-telemetry:main Sep 22, 2023
21 checks passed
@jdom jdom deleted the geneva-custom-name branch February 22, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yun-Ting Yun-Ting Yun-Ting approved these changes

@reyang reyang reyang approved these changes

@CodeBlanch CodeBlanch CodeBlanch approved these changes

@cijothomas cijothomas Awaiting requested review from cijothomas

@utpilla utpilla Awaiting requested review from utpilla

Assignees

@cijothomas cijothomas

@Yun-Ting Yun-Ting

@reyang reyang

@CodeBlanch CodeBlanch

@utpilla utpilla

Labels
comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

My 'name' field override by geneva exporter
7 participants
@jdom @Yun-Ting @reyang @CodeBlanch @cijothomas @Kielek @utpilla