Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrumentation.AWS] Bump minimal AWS SDKs to 3.7.300 #1542

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

martincostello
Copy link
Contributor

@martincostello martincostello commented Jan 20, 2024

Changes

Bump AWS SDKs to 3.7.300 for native AoT support.

Without this change, there are two AoT warnings when building the project from the AWS.Core library.

D:\JenkinsWorkspaces\trebuchet-stage-release\AWSDotNetPublic\sdk\src\Core\Amazon.Util\Internal\_netstandard\TypeWrapper.netstandard.cs(184): Trim analysis error IL2080: Amazon.Util.Internal.TypeFactory.TypeInfoWrapper.GetMethod(String,ITypeInfo[]): 'this' argument does not satisfy 'DynamicallyAccessedMemberTypes.PublicMethods' in call to 'System.Type.GetMethod(String,Type[])'. The field 'Amazon.Util.Internal.TypeFactory.AbstractTypeInfo._type' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to. [C:\Coding\open-telemetry\opentelemetry-dotnet-contrib\test\OpenTelemetry.AotCompatibility.TestApp\OpenTelemetry.AotCompatibility.TestApp.csproj]
D:\JenkinsWorkspaces\trebuchet-stage-release\AWSDotNetPublic\sdk\src\Core\Amazon.Util\Internal\_netstandard\TypeWrapper.netstandard.cs(68): Trim analysis error IL2080: Amazon.Util.Internal.TypeFactory.TypeInfoWrapper.GetField(String): 'this' argument does not satisfy 'DynamicallyAccessedMemberTypes.PublicFields' in call to 'System.Type.GetField(String)'. The field 'Amazon.Util.Internal.TypeFactory.AbstractTypeInfo._type' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to. [C:\Coding\open-telemetry\opentelemetry-dotnet-contrib\test\OpenTelemetry.AotCompatibility.TestApp\OpenTelemetry.AotCompatibility.TestApp.csproj]
  • Appropriate CHANGELOG.md updated for non-trivial changes

Bump AWS SDKs to 3.7.300 for native AoT support.
Copy link

codecov bot commented Jan 20, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (71655ce) 73.91% compared to head (5e027e4) 80.58%.
Report is 119 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1542      +/-   ##
==========================================
+ Coverage   73.91%   80.58%   +6.66%     
==========================================
  Files         267      113     -154     
  Lines        9615     3054    -6561     
==========================================
- Hits         7107     2461    -4646     
+ Misses       2508      593    -1915     
Flag Coverage Δ
unittests-Solution 80.58% <88.57%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...Telemetry.Exporter.InfluxDB/InfluxDBEventSource.cs 60.00% <ø> (ø)
...ry.Exporter.InfluxDB/InfluxDBExporterExtensions.cs 100.00% <100.00%> (ø)
...metry.Exporter.InfluxDB/InfluxDBMetricsExporter.cs 84.61% <ø> (-3.85%) ⬇️
...Telemetry.Exporter.InfluxDB/PointDataExtensions.cs 87.50% <100.00%> (ø)
...ry.Exporter.InfluxDB/TelegrafPrometheusWriterV1.cs 100.00% <ø> (ø)
...ry.Exporter.InfluxDB/TelegrafPrometheusWriterV2.cs 100.00% <ø> (ø)
...stana/Implementation/InstanaExporterEventSource.cs 0.00% <ø> (ø)
...try.Exporter.Instana/Implementation/InstanaSpan.cs 100.00% <ø> (ø)
...orter.Instana/Implementation/InstanaSpanFactory.cs 100.00% <ø> (ø)
...er.Instana/Implementation/InstanaSpanSerializer.cs 93.79% <ø> (ø)
... and 32 more

... and 224 files with indirect coverage changes

@martincostello martincostello marked this pull request as ready for review January 20, 2024 17:27
@martincostello martincostello requested a review from a team as a code owner January 20, 2024 17:27
@Kielek Kielek added the comp:instrumentation.aws Things related to OpenTelemetry.Instrumentation.AWS label Jan 22, 2024
@Kielek
Copy link
Contributor

Kielek commented Jan 22, 2024

FYI @srprash. @atshaw43, @ppittle, @birojnayak, @normj

Copy link
Contributor

@normj normj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good and @martincostello is correct version 3.7.300 is where the SDK addressed AOT warnings.

@Kielek Kielek changed the title Bump AWS SDKs [Instrumentation.AWS] Bump minimal AWS SDKs to 3.7.300 Jan 22, 2024
@cijothomas cijothomas merged commit 75a7f38 into open-telemetry:main Jan 22, 2024
32 checks passed
@martincostello martincostello deleted the bump-aws-sdks branch January 22, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.aws Things related to OpenTelemetry.Instrumentation.AWS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants