Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release native AoT fixes for AWS packages #1551

Merged

Conversation

martincostello
Copy link
Contributor

Fixes #1523, #1543.

Changes

Release native AoT fixes for:

  • Appropriate CHANGELOG.md updated for non-trivial changes

/cc @open-telemetry/dotnet-contrib-maintainers

Release native AoT fixes for:
- OpenTelemetry.Instrumentation.AWS
- OpenTelemetry.Instrumentation.AWSLambda
- OpenTelemetry.ResourceDetectors.AWS
@martincostello
Copy link
Contributor Author

FYI @normj

Copy link
Member

@Oberon00 Oberon00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, only checked the AWSLambda part

@cijothomas
Copy link
Member

@vishweshbankwar Can you do this release? Lets make sure you have all the required permissions to do a release.

@Kielek
Copy link
Contributor

Kielek commented Jan 26, 2024

In general looks good, please also check if there is no need to bump dependencies between AWS packages. As I remember, there is some of them.

@vishweshbankwar vishweshbankwar merged commit d1f2777 into open-telemetry:main Jan 26, 2024
26 checks passed
@martincostello martincostello deleted the release-native-aot-fixes branch January 26, 2024 19:11
@martincostello
Copy link
Contributor Author

The two Instrumentation assemblies just depend on Extensions.AWS, which doesn't need updating AFAIK:

<PackageReference Include="OpenTelemetry.Extensions.AWS" Version="1.3.0-beta.1" />

<PackageReference Include="OpenTelemetry.Extensions.AWS" Version="1.3.0-beta.1" />

@normj
Copy link
Contributor

normj commented Jan 26, 2024

Awesome job @martincostello getting these updates out.

@vishweshbankwar
Copy link
Member

FYI - All 3 packages have been released.

@martincostello
Copy link
Contributor Author

Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting rid of Newtonsoft.Json dependency in OpenTelemetry.Instrumentation.AWSLambda
8 participants