Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrumentation.AWSLambda] Update to net6.0 #1545

Merged

Conversation

martincostello
Copy link
Contributor

Contributes to #1523.

Changes

Spun off from #1544.

Target net6.0 instead of netstandard2.0 as AWS Lambda no longer supports versions of .NET less than .NET 6.

  • Appropriate CHANGELOG.md updated for non-trivial changes

Target `net6.0` instead of `netstandard2.0` as AWS Lambda no longer supports versions of .NET less than .NET 6.
Add the right PR number.
@Kielek Kielek added the comp:instrumentation.awslambda Things related to OpenTelemetry.Instrumentation.AWSLambda label Jan 22, 2024
Use `not null` instead of `{ }` to address feedback.
Fix syntax so it compiles.
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (71655ce) 73.91% compared to head (b99dc5a) 80.58%.
Report is 120 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1545      +/-   ##
==========================================
+ Coverage   73.91%   80.58%   +6.67%     
==========================================
  Files         267      113     -154     
  Lines        9615     3055    -6560     
==========================================
- Hits         7107     2462    -4645     
+ Misses       2508      593    -1915     
Flag Coverage Δ
unittests-Solution 80.58% <88.57%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...Telemetry.Exporter.InfluxDB/InfluxDBEventSource.cs 60.00% <ø> (ø)
...ry.Exporter.InfluxDB/InfluxDBExporterExtensions.cs 100.00% <100.00%> (ø)
...metry.Exporter.InfluxDB/InfluxDBMetricsExporter.cs 84.61% <ø> (-3.85%) ⬇️
...Telemetry.Exporter.InfluxDB/PointDataExtensions.cs 87.50% <100.00%> (ø)
...ry.Exporter.InfluxDB/TelegrafPrometheusWriterV1.cs 100.00% <ø> (ø)
...ry.Exporter.InfluxDB/TelegrafPrometheusWriterV2.cs 100.00% <ø> (ø)
...stana/Implementation/InstanaExporterEventSource.cs 0.00% <ø> (ø)
...try.Exporter.Instana/Implementation/InstanaSpan.cs 100.00% <ø> (ø)
...orter.Instana/Implementation/InstanaSpanFactory.cs 100.00% <ø> (ø)
...er.Instana/Implementation/InstanaSpanSerializer.cs 93.79% <ø> (ø)
... and 32 more

... and 224 files with indirect coverage changes

- Hard-code the name, rather than use reflection that might fail in native AoT.
- Use `[AssemblyFileVersionAttribute]` to get the version for the same reason.
Revert change to syntax to the terser version.
@martincostello martincostello marked this pull request as ready for review January 22, 2024 12:29
@martincostello martincostello requested a review from a team as a code owner January 22, 2024 12:29
Use `[AssemblyInformationalVersion]` so pre-release version information is included, but remove the Git SHA.
@Kielek Kielek merged commit b21a0f9 into open-telemetry:main Jan 22, 2024
32 checks passed
@martincostello martincostello deleted the instrumentation-awslambda-net6 branch January 22, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.awslambda Things related to OpenTelemetry.Instrumentation.AWSLambda
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants