Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Shared/ActivityInstrumentationHelper #1663

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Apr 19, 2024

Towards open-telemetry/opentelemetry-dotnet#5526

Changes

Sync Shared/ActivityInstrumentationHelper
based on https://github.com/open-telemetry/opentelemetry-dotnet/tree/89aa7a47ab070dda5a6eb470c352293cd366425c

Needed for SqlClient Instrumentation. Related to AOT compilation stuff.

For significant contributions please make sure you have completed the following items:

  • [ ] Appropriate CHANGELOG.md updated for non-trivial changes
  • [ ] Design discussion issue #
  • [ ] Changes in public API reviewed

@Kielek Kielek requested a review from a team as a code owner April 19, 2024 05:22
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.61%. Comparing base (71655ce) to head (2b5b28f).
Report is 196 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1663      +/-   ##
==========================================
+ Coverage   73.91%   74.61%   +0.69%     
==========================================
  Files         267      263       -4     
  Lines        9615     9949     +334     
==========================================
+ Hits         7107     7423     +316     
- Misses       2508     2526      +18     
Flag Coverage Δ
unittests-Exporter.Geneva 62.51% <ø> (?)
unittests-Exporter.OneCollector 89.72% <ø> (?)
unittests-Extensions 82.75% <ø> (?)
unittests-Instrumentation.AspNet 77.11% <ø> (?)
unittests-Instrumentation.EventCounters 76.36% <ø> (?)
unittests-Instrumentation.Owin 83.43% <ø> (?)
unittests-Instrumentation.Process 100.00% <ø> (?)
unittests-Instrumentation.Runtime 100.00% <ø> (?)
unittests-Instrumentation.StackExchangeRedis 71.00% <ø> (?)
unittests-Instrumentation.Wcf 78.47% <ø> (?)
unittests-PersistentStorage 65.44% <ø> (?)
unittests-ResourceDetectors.Azure 81.53% <ø> (?)
unittests-ResourceDetectors.Host 54.11% <ø> (?)
unittests-ResourceDetectors.Process 100.00% <ø> (?)
unittests-ResourceDetectors.ProcessRuntime 76.08% <ø> (?)
unittests-Solution 79.67% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 210 files with indirect coverage changes

@Kielek Kielek merged commit 972cc66 into open-telemetry:main Apr 19, 2024
112 of 113 checks passed
@Kielek Kielek deleted the sync-ActivityInstrumentationHelper branch April 19, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants