Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrumentation.GrpcNetClient] Move package from main repository #1704

Merged

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented May 6, 2024

Towards open-telemetry/opentelemetry-dotnet#5526

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@Kielek Kielek added the comp:instrumentation.grpcnetclient Things related to OpenTelemetry.Instrumentation.GrpcNetClient label May 6, 2024
@Kielek Kielek requested a review from a team as a code owner May 6, 2024 10:33
Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 81.96721% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 75.85%. Comparing base (71655ce) to head (850f4f8).
Report is 224 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1704      +/-   ##
==========================================
+ Coverage   73.91%   75.85%   +1.93%     
==========================================
  Files         267      287      +20     
  Lines        9615    11181    +1566     
==========================================
+ Hits         7107     8481    +1374     
- Misses       2508     2700     +192     
Flag Coverage Δ
unittests-Exporter.Geneva 63.38% <ø> (?)
unittests-Exporter.OneCollector 89.72% <ø> (?)
unittests-Extensions 79.33% <ø> (?)
unittests-Instrumentation.AspNet 74.69% <ø> (?)
unittests-Instrumentation.EventCounters 76.36% <ø> (?)
unittests-Instrumentation.GrpcNetClient 81.96% <81.96%> (?)
unittests-Instrumentation.Http 81.79% <ø> (?)
unittests-Instrumentation.Owin 83.43% <ø> (?)
unittests-Instrumentation.Process 100.00% <ø> (?)
unittests-Instrumentation.Runtime 100.00% <ø> (?)
unittests-Instrumentation.SqlClient 90.90% <ø> (?)
unittests-Instrumentation.StackExchangeRedis 71.00% <ø> (?)
unittests-Instrumentation.Wcf 78.47% <ø> (?)
unittests-PersistentStorage 65.78% <ø> (?)
unittests-ResourceDetectors.Azure 81.53% <ø> (?)
unittests-ResourceDetectors.Host 54.11% <ø> (?)
unittests-ResourceDetectors.Process 100.00% <ø> (?)
unittests-ResourceDetectors.ProcessRuntime 76.08% <ø> (?)
unittests-Solution 80.17% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ntation.GrpcNetClient/GrpcClientInstrumentation.cs 100.00% <100.00%> (ø)
...NetClient/GrpcClientTraceInstrumentationOptions.cs 100.00% <100.00%> (ø)
...n.GrpcNetClient/TracerProviderBuilderExtensions.cs 100.00% <100.00%> (ø)
...try.Instrumentation.GrpcNetClient/GrpcTagHelper.cs 95.65% <95.65%> (ø)
...t/Implementation/GrpcInstrumentationEventSource.cs 53.84% <53.84%> (ø)
...ent/Implementation/GrpcClientDiagnosticListener.cs 76.19% <76.19%> (ø)

... and 244 files with indirect coverage changes

@Kielek Kielek merged commit 6aed975 into open-telemetry:main May 6, 2024
140 of 141 checks passed
@Kielek Kielek deleted the migrate-grpcnetclientinstrumentation branch May 6, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.grpcnetclient Things related to OpenTelemetry.Instrumentation.GrpcNetClient
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants