[Instrumentation.GrpcNetClient] Move to contrib repository #5593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It will be again common after migration to contrib repository
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5593 +/- ##
==========================================
+ Coverage 83.38% 85.36% +1.97%
==========================================
Files 297 265 -32
Lines 12531 11273 -1258
==========================================
- Hits 10449 9623 -826
+ Misses 2082 1650 -432
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There is no package supporting it
reyang
reviewed
May 6, 2024
reyang
reviewed
May 6, 2024
| @@ -21,12 +21,12 @@ | |||
| <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets> | |||
| </PackageReference> | |||
| <PackageReference Include="OpenTelemetry.Instrumentation.Http" /> | |||
| <PackageReference Include="OpenTelemetry.Instrumentation.GrpcNetClient" /> | |||
There was a problem hiding this comment.
I vote for removing this dependency and the corresponding example code entirely from this repo.
There was a problem hiding this comment.
I would handle it separately when all packages are migrated. It will be easier to decide what to move and what we can just remove.
vishweshbankwar
approved these changes
May 7, 2024
rajkumar-rangaraj
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards: #5526
Related to: open-telemetry/opentelemetry-dotnet-contrib#1704
Changes
[Instrumentation.GrpcNetClient] Move to contrib repository
Merge requirement checklist
[ ] AppropriateCHANGELOG.mdfiles updated for non-trivial changes[ ] Changes in public API reviewed (if applicable)