-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Instrumentation.Runtime] Remove gc.heap.fragmentation.size
metrics due to buggy API on .NET 6
#509
[Instrumentation.Runtime] Remove gc.heap.fragmentation.size
metrics due to buggy API on .NET 6
#509
Conversation
Codecov Report
@@ Coverage Diff @@
## main #509 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 167 167
Lines 5098 5077 -21
=====================================
+ Misses 5098 5077 -21
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add net7.0 target to the tests project and validate this as well?
I validated locally for .NET 7.0. However both the runtime library and the test project have to have |
Then its best to not rely on compiler preprocessor directives. You should switch to using Environment.Version to detect .NET 6 vs .NET 7, so that this can be used in .NET 7 apps right now. |
Added it back in #524. |
Removing this metrics because of the same issue #496. Unfortunately there is no convenient alternative API for this metric.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changesGC.GetGCMemoryInfo().GenerationInfo[i].SizeAfterBytes
for .NET 7 #496