Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrumentation.Runtime] Add gc.heap.fragmentation.size back for .NET 7 and later #524

Merged
merged 2 commits into from
Jul 21, 2022

Conversation

xiang17
Copy link
Contributor

@xiang17 xiang17 commented Jul 21, 2022

Changes

#509 intended to only remove the metrics for .NET 6.

For .NET 7 and later, the metrics should be available.

For significant contributions please make sure you have completed the following items:

@xiang17 xiang17 requested a review from a team as a code owner July 21, 2022 00:07
@xiang17 xiang17 changed the title Add gc.heap.fragmentation.size back for .NET 7 and later [Instrumentation.Runtime] Add gc.heap.fragmentation.size back for .NET 7 and later Jul 21, 2022
@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #524 (e0a3431) into main (b4f4a7e) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #524   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files        167     167           
  Lines       5076    5098   +22     
=====================================
- Misses      5076    5098   +22     
Impacted Files Coverage Δ
...elemetry.Instrumentation.Runtime/RuntimeMetrics.cs 0.00% <0.00%> (ø)

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider adding to changelog

@utpilla utpilla added comp:instrumentation.wcf Things related to OpenTelemetry.Instrumentation.Wcf comp:instrumentation.runtime Things related to OpenTelemetry.Instrumentation.Runtime and removed comp:instrumentation.wcf Things related to OpenTelemetry.Instrumentation.Wcf labels Jul 21, 2022
@cijothomas cijothomas merged commit b9c9f4b into open-telemetry:main Jul 21, 2022
@xiang17 xiang17 deleted the xiang17/FragmentationSize branch July 21, 2022 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.runtime Things related to OpenTelemetry.Instrumentation.Runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants