[Exporter.Geneva] Move TableNameMappings checks to GenevaExporterOptions class #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
assigned cijothomas, CodeBlanch, mic-max, reyang, utpilla and Yun-Ting
github-actions
bot
requested review from
cijothomas,
CodeBlanch,
mic-max,
reyang and
Yun-Ting
utpilla
commented
Sep 16, 2022
| { | ||
| throw new ArgumentNullException(entry.Key, $"{nameof(this.TableNameMappings)} must not contain null values."); | ||
| throw new ArgumentException($"A string-typed value provided for {nameof(this.TableNameMappings)} must not be null, empty, or consist only of white-space characters."); |
There was a problem hiding this comment.
This check didn't exist for GenevaLogExporter.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #646 +/- ##
==========================================
+ Coverage 77.74% 77.78% +0.04%
==========================================
Files 170 170
Lines 5158 5154 -4
==========================================
- Hits 4010 4009 -1
+ Misses 1148 1145 -3
|
cijothomas
approved these changes
Sep 17, 2022
utpilla
added
the
comp:exporter.geneva
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
TableNameMappingschecks fromGenevaTraceExporterandGenevaLogExporterctor toGenevaExporterOptionsclassPlease provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes