Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Exporter.Geneva] Fix EventSource logging for GenevaExporter #813

Merged
merged 3 commits into from
Dec 9, 2022
Merged

[Exporter.Geneva] Fix EventSource logging for GenevaExporter #813

merged 3 commits into from
Dec 9, 2022

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Dec 9, 2022 •
edited
Loading

Fixes #753

Changes

  • Fix EventSource logging for GenevaExporter

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes

@utpilla utpilla added the comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva label Dec 9, 2022
@utpilla utpilla requested a review from a team December 9, 2022 03:45
CodeBlanch
CodeBlanch approved these changes Dec 9, 2022
View reviewed changes
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment but otherwise LGTM

@utpilla utpilla merged commit ff92fa3 into open-telemetry:main Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cijothomas cijothomas Awaiting requested review from cijothomas

@mic-max mic-max Awaiting requested review from mic-max

@reyang reyang Awaiting requested review from reyang

@Yun-Ting Yun-Ting Awaiting requested review from Yun-Ting

@CodeBlanch CodeBlanch Awaiting requested review from CodeBlanch

Assignees

@cijothomas cijothomas

@mic-max mic-max

@Yun-Ting Yun-Ting

@reyang reyang

@CodeBlanch CodeBlanch

@utpilla utpilla

Labels
comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ExporterEventSource fails to export events due to Exceptions in method signatures
6 participants
@utpilla @CodeBlanch @cijothomas @mic-max @Yun-Ting @reyang