-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrading Elasticsearch to OTel version 1.0.2 #83
Conversation
Codecov Report
@@ Coverage Diff @@
## main #83 +/- ##
==========================================
- Coverage 73.16% 72.62% -0.55%
==========================================
Files 41 40 -1
Lines 1077 1063 -14
==========================================
- Hits 788 772 -16
- Misses 289 291 +2
|
...strumentation.Elasticsearch/OpenTelemetry.Contrib.Instrumentation.ElasticsearchClient.csproj
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Contrib.Instrumentation.Elasticsearch/TracerProviderBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
...strumentation.Elasticsearch/Implementation/ElasticsearchRequestPipelineDiagnosticListener.cs
Show resolved
Hide resolved
.../OpenTelemetry.Contrib.Instrumentation.ElasticsearchClient.Tests/ElasticsearchClientTests.cs
Outdated
Show resolved
Hide resolved
.../OpenTelemetry.Contrib.Instrumentation.ElasticsearchClient.Tests/ElasticsearchClientTests.cs
Outdated
Show resolved
Hide resolved
...ry.Contrib.Instrumentation.Elasticsearch/Implementation/ElasticsearchActivitySourceHelper.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes to move away from ActivitySourceAdapater is good and the tests confirm its working.
@ejsmith could you update the PR title and description to match the current state. |
@cijothomas I'm still waiting for resolution on open-telemetry/opentelemetry-dotnet#1856 because I need access to |
…ass. Fix formatting issues.
@cijothomas is the title and description better now? All the checks should be passing now as well. |
I’ve updated the instrumentation for MassTransit and EntityFrameworkCore. But I have to add the same shared files, like in this PR. |
Still waiting for resolution on open-telemetry/opentelemetry-dotnet#1856 before this can be merged. I'm attempting to wait patiently. 😆 |
Thanks for waiting! |
src/OpenTelemetry.Contrib.Shared/DiagnosticSourceInstrumentation/DiagnosticSourceListener.cs
Outdated
Show resolved
Hide resolved
Adapt changes like this open-telemetry/opentelemetry-dotnet#1893 and this should unblock this PR including the supressdownstream functionality. |
@cijothomas done |
This PR upgrades the Elasticsearch instrumentation to OTel version 1.0.2 and serves as an example of how to get rid of
ActivitySourceAdapter
as well as use the newAddLegacyActivity
method.It also adds a new
OpenTelemetry.Contrib.Shared
project that contains all of the source shared from the main OTel .NET library that is necessary to create new instrumentations. The library is not meant to be directly referenced. Instead an instrumentation library should use theIncludeSharedInstrumentationSource
MSBuild property in order to have the shared source files included in their project.