[docs-traces] Added version info to the OTEL_TRACES_SAMPLER doc (#5492)

open-telemetry · Mar 29, 2024 · 39d960e · 39d960e
1 parent 2e30089
commit 39d960e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/docs/trace/customizing-the-sdk/README.md b/docs/trace/customizing-the-sdk/README.md
@@ -363,8 +363,8 @@ var tracerProvider = Sdk.CreateTracerProviderBuilder()
     .Build();
 ```
 
-It is also possible to configure the sampler by using the following
-environmental variables:
+If using `1.8.0-rc.1` or newer it is also possible to configure the sampler by
+using the following environmental variables:
 
 | Environment variable       | Description                                        |
 | -------------------------- | -------------------------------------------------- |

diff --git a/src/OpenTelemetry/Trace/TracerProviderSdk.cs b/src/OpenTelemetry/Trace/TracerProviderSdk.cs
@@ -407,12 +407,7 @@ protected override void Dispose(bool disposing)
 
     private static Sampler GetSampler(IConfiguration configuration, Sampler? stateSampler)
     {
-        Sampler? sampler = null;
-
-        if (stateSampler != null)
-        {
-            sampler = stateSampler;
-        }
+        var sampler = stateSampler;
 
         if (configuration.TryGetStringValue(TracesSamplerConfigKey, out var configValue))
         {