Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-traces] Added version info to the OTEL_TRACES_SAMPLER doc #5492

Merged

Conversation

CodeBlanch
Copy link
Member

Follow-up to #5448

Changes

  • Adds release version info to the OTEL_TRACES_SAMPLER doc.
  • Improve the code ever so slightly.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)

@CodeBlanch CodeBlanch requested a review from a team as a code owner March 29, 2024 18:11
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.51%. Comparing base (6250307) to head (2ff0358).
Report is 154 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5492      +/-   ##
==========================================
+ Coverage   83.38%   85.51%   +2.12%     
==========================================
  Files         297      289       -8     
  Lines       12531    12591      +60     
==========================================
+ Hits        10449    10767     +318     
+ Misses       2082     1824     -258     
Flag Coverage Δ
unittests ?
unittests-Solution-Experimental 85.50% <100.00%> (?)
unittests-Solution-Stable 85.26% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/OpenTelemetry/Trace/TracerProviderSdk.cs 99.36% <100.00%> (+0.08%) ⬆️

... and 64 files with indirect coverage changes

@CodeBlanch CodeBlanch merged commit 39d960e into open-telemetry:main Mar 29, 2024
37 checks passed
@CodeBlanch CodeBlanch deleted the sdk-sampler-envvar-updates branch March 29, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants