[sdk-metrics] Update Exemplars before MetricPoint CompleteUpdate fires (

#5630)
open-telemetry · May 17, 2024 · a9c32c9 · a9c32c9
1 parent 8177a39
commit a9c32c9
Showing 1 changed file with 16 additions and 16 deletions.
diff --git a/src/OpenTelemetry/Metrics/MetricPoint.cs b/src/OpenTelemetry/Metrics/MetricPoint.cs
@@ -492,9 +492,9 @@ internal void UpdateWithExemplar(long number, ReadOnlySpan<KeyValuePair<string,
                 }
         }
 
-        this.CompleteUpdate();
-
         this.UpdateExemplar(number, tags, offerExemplar);
+
+        this.CompleteUpdate();
     }
 
     internal void Update(double number)
@@ -608,9 +608,9 @@ internal void UpdateWithExemplar(double number, ReadOnlySpan<KeyValuePair<string
                 }
         }
 
-        this.CompleteUpdate();
-
         this.UpdateExemplar(number, tags, offerExemplar);
+
+        this.CompleteUpdate();
     }
 
     internal void TakeSnapshot(bool outputDelta)
@@ -899,9 +899,9 @@ private void UpdateHistogram(double number, ReadOnlySpan<KeyValuePair<string, ob
 
         this.mpComponents.ReleaseLock();
 
-        this.CompleteUpdate();
-
         this.UpdateExemplar(number, tags, offerExemplar);
+
+        this.CompleteUpdate();
     }
 
     private void UpdateHistogramWithMinMax(double number, ReadOnlySpan<KeyValuePair<string, object?>> tags = default, bool offerExemplar = false)
@@ -923,9 +923,9 @@ private void UpdateHistogramWithMinMax(double number, ReadOnlySpan<KeyValuePair<
 
         this.mpComponents.ReleaseLock();
 
-        this.CompleteUpdate();
-
         this.UpdateExemplar(number, tags, offerExemplar);
+
+        this.CompleteUpdate();
     }
 
     private void UpdateHistogramWithBuckets(double number, ReadOnlySpan<KeyValuePair<string, object?>> tags = default, bool offerExemplar = false)
@@ -947,9 +947,9 @@ private void UpdateHistogramWithBuckets(double number, ReadOnlySpan<KeyValuePair
 
         this.mpComponents.ReleaseLock();
 
-        this.CompleteUpdate();
-
         this.UpdateExemplar(number, tags, offerExemplar, bucketIndex);
+
+        this.CompleteUpdate();
     }
 
     private void UpdateHistogramWithBucketsAndMinMax(double number, ReadOnlySpan<KeyValuePair<string, object?>> tags = default, bool offerExemplar = false)
@@ -974,9 +974,9 @@ private void UpdateHistogramWithBucketsAndMinMax(double number, ReadOnlySpan<Key
 
         this.mpComponents.ReleaseLock();
 
-        this.CompleteUpdate();
-
         this.UpdateExemplar(number, tags, offerExemplar, bucketIndex);
+
+        this.CompleteUpdate();
     }
 
     private void UpdateBase2ExponentialHistogram(double number, ReadOnlySpan<KeyValuePair<string, object?>> tags = default, bool offerExemplar = false)
@@ -1002,9 +1002,9 @@ private void UpdateBase2ExponentialHistogram(double number, ReadOnlySpan<KeyValu
 
         this.mpComponents.ReleaseLock();
 
-        this.CompleteUpdate();
-
         this.UpdateExemplar(number, tags, offerExemplar);
+
+        this.CompleteUpdate();
     }
 
     private void UpdateBase2ExponentialHistogramWithMinMax(double number, ReadOnlySpan<KeyValuePair<string, object?>> tags = default, bool offerExemplar = false)
@@ -1033,9 +1033,9 @@ private void UpdateBase2ExponentialHistogramWithMinMax(double number, ReadOnlySp
 
         this.mpComponents.ReleaseLock();
 
-        this.CompleteUpdate();
-
         this.UpdateExemplar(number, tags, offerExemplar);
+
+        this.CompleteUpdate();
     }
 
     [MethodImpl(MethodImplOptions.AggressiveInlining)]