Adding service.namespace as tags for zipkin (#1521)

updating changelog updating changelog updating changelog Revert "Adding service.namespace as tags for zipkin" This reverts commit 1868e71b964fa030bc33ece441047b19fa221688. updating file and changelog
open-telemetry · Nov 12, 2020 · d1c174d · d1c174d
1 parent 4ab6da0
commit d1c174d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 11 deletions.
diff --git a/src/OpenTelemetry.Exporter.Zipkin/CHANGELOG.md b/src/OpenTelemetry.Exporter.Zipkin/CHANGELOG.md
@@ -4,6 +4,8 @@
 
 * Zipkin tags used for InstrumentationLibrary changed from library.name,
   library.version to otel.library.name, otel.library.version respectively.
+* Sending `service.namespace` as Zipkin tag.
+  ([#1521](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1521))
 
 ## 0.8.0-beta.1
 

diff --git a/src/OpenTelemetry.Exporter.Zipkin/ZipkinExporter.cs b/src/OpenTelemetry.Exporter.Zipkin/ZipkinExporter.cs
@@ -108,7 +108,6 @@ internal void SetLocalEndpointFromResource(Resource resource)
             }
 
             string serviceName = null;
-            string serviceNamespace = null;
             Dictionary<string, object> tags = null;
             foreach (var label in resource.Attributes)
             {
@@ -119,9 +118,6 @@ internal void SetLocalEndpointFromResource(Resource resource)
                     case Resource.ServiceNameKey:
                         serviceName = label.Value as string;
                         continue;
-                    case Resource.ServiceNamespaceKey:
-                        serviceNamespace = label.Value as string;
-                        continue;
                 }
 
                 if (tags == null)
@@ -132,13 +128,7 @@ internal void SetLocalEndpointFromResource(Resource resource)
                 tags[key] = label.Value;
             }
 
-            if (!string.IsNullOrEmpty(serviceName))
-            {
-                serviceName = serviceNamespace != null
-                    ? serviceNamespace + "." + serviceName
-                    : serviceName;
-            }
-            else
+            if (string.IsNullOrEmpty(serviceName))
             {
                 serviceName = this.options.ServiceName;
             }