Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export Instrumentation Scope attributes for a Meter (requires DiagnosticSource v8) #4563

Closed
alanwest opened this issue Jun 8, 2023 · 0 comments · Fixed by #5089
Closed

Export Instrumentation Scope attributes for a Meter (requires DiagnosticSource v8) #4563

alanwest opened this issue Jun 8, 2023 · 0 comments · Fixed by #5089
Labels
need-runtime-change Issues which likely require changes from dotnet runtime - typically DiagnosticSource changes pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package pkg:OpenTelemetry.Exporter.Prometheus.AspNetCore Issues related to OpenTelemetry.Exporter.Prometheus.AspNetCore NuGet package
Milestone
1.7.0

Comments

@alanwest
Copy link
Member

alanwest commented Jun 8, 2023

System.Diagnostics.DiagnosticSource v8.0 is introducing the ability to instantiate a Meter with tags

This satisfies the requirement from the spec to provide instrumentation scope attributes. See:
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/api.md#get-a-meter.

Once we bump our dependency to DiagnosticSource v8.0 we will need to update exporters to export these tags.
@alanwest alanwest added the enhancement New feature or request label Jun 8, 2023
@alanwest alanwest added this to the 1.7.0 milestone Jun 8, 2023
@alanwest alanwest added pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package pkg:OpenTelemetry.Exporter.Prometheus.AspNetCore Issues related to OpenTelemetry.Exporter.Prometheus.AspNetCore NuGet package need-runtime-change Issues which likely require changes from dotnet runtime - typically DiagnosticSource changes and removed enhancement New feature or request labels Jun 8, 2023
This was referenced Sep 27, 2023
Open
Closed
@robertcoltheart robertcoltheart mentioned this issue Nov 24, 2023
Closed
@cijothomas cijothomas mentioned this issue Nov 28, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
need-runtime-change Issues which likely require changes from dotnet runtime - typically DiagnosticSource changes pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package pkg:OpenTelemetry.Exporter.Prometheus.AspNetCore Issues related to OpenTelemetry.Exporter.Prometheus.AspNetCore NuGet package
Projects
None yet
Milestone
1.7.0
Development

Successfully merging a pull request may close this issue.

Add support for instrumentation scope attributes (Meter tags) cijothomas/opentelemetry-dotnet
1 participant
@alanwest