Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for instrumentation scope attributes (Meter tags) #5089

Merged
merged 21 commits into from
Nov 29, 2023

Conversation

cijothomas
Copy link
Member

@cijothomas cijothomas commented Nov 28, 2023

Fixes #4563

Did not touch Prometheus exporters in this PR, better to wait till #5086 is merged.

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@cijothomas cijothomas requested a review from a team as a code owner November 28, 2023 18:16
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Merging #5089 (3ac1cf5) into main (617ac6c) will decrease coverage by 0.10%.
Report is 2 commits behind head on main.
The diff coverage is 26.31%.

❗ Current head 3ac1cf5 differs from pull request most recent head c9e0eec. Consider uploading reports for the commit c9e0eec to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5089      +/-   ##
==========================================
- Coverage   83.36%   83.27%   -0.10%     
==========================================
  Files         296      296              
  Lines       12339    12355      +16     
==========================================
+ Hits        10287    10289       +2     
- Misses       2052     2066      +14     
Flag Coverage Δ
unittests 83.27% <26.31%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/OpenTelemetry/Metrics/Metric.cs 96.52% <100.00%> (+0.03%) ⬆️
src/OpenTelemetry/Metrics/MetricStreamIdentity.cs 86.66% <100.00%> (+0.30%) ⬆️
...elemetry.Exporter.Console/ConsoleMetricExporter.cs 0.00% <0.00%> (ø)
...tryProtocol/Implementation/MetricItemExtensions.cs 82.01% <20.00%> (-3.55%) ⬇️

... and 7 files with indirect coverage changes

@utpilla utpilla merged commit 97442ef into open-telemetry:main Nov 29, 2023
77 of 78 checks passed
@cijothomas cijothomas deleted the cijothomas/metertags branch November 29, 2023 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export Instrumentation Scope attributes for a Meter (requires DiagnosticSource v8)
5 participants